Split L1 ByteStream decoding and L1TriggerResult creation

This is continuation of the development started in !29361 (merged). Discussing in Trigger Core Software meeting and in ATR-20745, we decided to split the BS decoding part and the L1TriggerResult creation part. The former L1TriggerResultMaker is thus split into:

• L1TriggerByteStreamDecoderAlg in the TrigT1ByteStream package (only gathers raw data and calls tools doing BS->xAOD conversion)
• L1TriggerResultMaker in the L1Decoder package (only creates L1TriggerResult and links the xAOD L1 collections to it)

Any reference to L1TriggerResult is removed from TrigT1ByteStream and is encapsulated within the L1Decoder package.

Tested with:

athenaHLT.py -l DEBUG -c "doEmptyMenu=True;BFieldAutoConfig=False;decodePhaseIL1=True;" -n 20 -f /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/TrigP1Test/data18_13TeV.00360026.physics_EnhancedBias.merge.RAW._lb0151._SFO-1._0001.1 TriggerJobOpts/runHLT_standalone.py

This merge request affects 3 packages:

• Trigger/TrigSteer/L1Decoder
• Trigger/TrigT1/TrigT1ResultByteStream
• Trigger/TriggerCommon/TriggerJobOpts

Adding @tamartin ,@kwhalen ,@afaulkne as watchers

added Trigger master review-pending-level-1 labels

CI Result FAILURE (hash 41dbad0e)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9817]

Hi, the Trigger_MT_required-test failed, any idea why? thanks, L1

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

Hi @mghneima,
I think you may have misclicked the label and accidentally approved. I changed back to review-user-action-required. I know why this failed - I forgot about one piece of configuration. I'll fix this soon.

Cheers,
Rafal

resolved all threads

added 27 commits

• 41dbad0e...3694889b - 25 commits from branch atlas:master
• cc98c49c - Split L1 BS decoding and L1TriggerResult creation
• e30394c8 - Add L1TriggerResultMaker in NewJO config

Compare with previous version

changed the description

This merge request affects 3 packages:

• Trigger/TrigSteer/L1Decoder
• Trigger/TrigT1/TrigT1ResultByteStream
• Trigger/TriggerCommon/TriggerJobOpts

Adding @tamartin ,@kwhalen ,@afaulkne as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash e30394c8)

	Athena	AthSimulation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 9835]

The code looks good to me, but due to the size of this MR, I would like L2 to have a second look. Cheers, Timo (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

Hi @tidreyer (L1), @abarton (RC),
there are no L2 shifters this week at all:

How can we proceed?

Cheers,
Rafal

@rbielski Stewart maybe able to get around to it, but if you want to confirm you are confident in it yourself and I see no issues. I will merge it.

Don't want to approve my own MR, so another look from someone else would be welcome. But if no one is available, I'm of course also happy to have this merged.

added review-approved label and removed review-pending-level-2 label

Approved (L2)

merged

mentioned in commit b0f9d18c

added sweep:ignore label

mentioned in merge request !30680 (merged)