Skip to content

In det config

Edward Moyse requested to merge InDetConfig into master

Copied from !30262 (merged)

This is still very much work in progress, I've started converting the condAlgs and tools needed to create the InDetTrackSummaryTool using the new configuration.

Most of the functionality is converted from TrackingCommon.py and InDetRecConditionsAccess.py and the files imported in these.

For now I just put all configuration in one file InDetRecToolConfig.py, if you think e.g. the ConditionsAlgs should be setup in a separate file that's fine by me. The advantage for now is that everything that is called must be defined in here, if it doesn't exist here it must still be implemented (i.e. grep for Cfg and check if there's a function for each of them).

I've also added the InDetConfigFlags.py, for which I just pulled all flags from the original file, removed all the logic and set the defaults. Ed mentioned the flags still need to be added somewhere to be accessible.

I have NOT started changing public tools that should be private and some of the configuration would definitely not pass a review. I added comments with "FIXME" where I was either told "yes this is bad but don't bother fixing it as we'll put in Acts" (that's the Extrapolator) or where I actually have a concern. A fixme may also come from the code from which I copied...

I added some function stubs I didn't convert yet where the only thing I put is "setPrivateTools" or "addPublicTool" as a reminder how each tool must be setup (barring changes on the C++ side).

Merge request reports