Updated recommendations from MCP on MuonMomentumCorrections

This merge request is mainly done to include the latest available muon momentum corrections (labeled as Recs2020_03_03) to the 21.2 releases.

As we are anyway too late for this release, we are changing the location of the calibration files. As soon as those are replicated to /cvmfs we will remove the WIP: and proceed with the merge.

Here is a list of all the changes that were introduced in this version of the package:

• MuonCalibrationAndSmearingTool and MuonCalibrationPeriodTool have been updated to automatically pick up the latest available calibrations (Recs2020_03_03). Please note that, starting from this version, the calibration files are stored in a sub-directory of /eos/atlas/atlascerngroupdisk/asg-calib/MuonMomentumCorrections with the same name of the corrections' release.
• A new property has been introduced (AddExtraDecorations) to allow the (expert) user to add extra decorations to an xAOD::Muon object corrected by the tool for debugging purposes. This property is set to False by default and should only be used by experts.
• A new property has been introduced (do2StationsHighPt) to included appropriate momentum corrections for two-station muons passing the HighPt selection criteria. This property is set to False by default and should only be activated by those users of the HighPt selection that are also including good two-station muons. This feature applies only to muons with p_T > 300 GeV.
• A new property has been introduced (doExtraSmearing) to allow users (not explicitly using the HighPt selection) to check whether their analysis is sensitive to resolution effects for highly energetic muons. This property is set to False by default. This feature applies only to muons with p_T > 300 GeV.
• A general cleanup of some parts of the tool has been made (especially those concerning MeV->GeV and GeV->MeV conversions)
• The code in src/, used by experts for debugging purposes has also been improved to follow these latest developments. This, however, should not have any impact on the standard ATLAS user.

In order to pick up the correct information for the different types of muons and apply the appropriate corrections, MuonCalibrationAndSmearingTool now uses an instance of the MuonSelectionTool internally.

added 21.2 + 1 deleted label

changed the description

changed target branch from master to 21.2

WARNING: big files (>100K) are found in the changeset

136K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

WARNING: big files (>100K) are found in the changeset

136K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

Adding @fsforza ,@szambito ,@gabarone ,@nkoehler ,@gartoni ,@jojungge as watchers

added Analysis review-pending-level-1 labels

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result FAILURE (hash 090c1212)

	AnalysisBase	AthAnalysis
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AnalysisBase: number of compilation errors 2, warnings 125
AthAnalysis: number of compilation errors 0, warnings 4
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10098]

Is CLHEP part of AnalysisBase?

===========================================================================
[ATLAS Nightly System]: logfile build.x86_64-centos7-gcc8-opt/BuildLogs/MuonMomentumCorrections.log
===========================================================================
# Version: N/A
# CMake ---> /cvmfs/atlas.cern.ch/repo/ATLASLocalRootBase/x86_64/Cmake/3.14.3/Linux-x86_64/bin/cmake -E make_directory /build2/ci-builds/21.2/AnalysisBase/build/AnalysisBase/x86_64-centos7-gcc8-opt/lib
# CMake ---> /build2/ci-builds/21.2/AnalysisBase/build/AnalysisBase/atlas_build_run.sh /usr/bin/bash /build2/ci-builds/21.2/AnalysisBase/build/AnalysisBase/PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/CMakeFiles/makeMuonMomentumCorrectionsDictReflexDict.sh
In file included from input_line_9:51:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/21.2/PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibrationAndSmearingTool.h:11:10: fatal error: 'CLHEP/Units/SystemOfUnits.h' file not found
#include <CLHEP/Units/SystemOfUnits.h>
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Error: rootcling: compilation failure (./libMuonMomentumCorrectionsDict45f0490641_dictUmbrella.h)
error: Failed to execute /build2/ci-builds/21.2/AnalysisBase/build/AnalysisBase/atlas_build_run.sh /usr/bin/bash /build2/ci-builds/21.2/AnalysisBase/build/AnalysisBase/PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/CMakeFiles/makeMuonMomentumCorrectionsDictReflexDict.sh (return code: 1)
Warning: the last line does not indicate that the package build is successful

Hi @jojungge,

You should probably add a dependency on CLHEP to your CMakeLists.txt file.

Cheers, Nils

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash 090c1212)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 10
For experts only: Jenkins output [CI-MERGE-REQUEST 42814]

added 1 commit

• ee82b7b8 - removed dependency on CLHEP

Compare with previous version

WARNING: big files (>100K) are found in the changeset

136K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

build area is cleaned as the previous build was for the MR labeled as full-build

WARNING: big files (>100K) are found in the changeset

136K in file PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibrationAndSmearingTool.cxx

This merge request affects 1 package:

• PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

Adding @fsforza ,@szambito ,@gabarone ,@nkoehler ,@gartoni ,@jojungge as watchers

Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

• Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.

CI Result SUCCESS (hash ee82b7b8)

	AthDerivation
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
AthDerivation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 42818]