Skip to content
Snippets Groups Projects

TrigValSteering: Memoize path lookup and add more debug messages

Merged Rafal Bielski requested to merge rbielski/athena:tvs-memoize-path-lookup into master
All threads resolved!

This should hopefully fix ATR-21080. The slowest part of the test configuration, and therefore the unit tests, is the path lookup with find_data and get_files. Since they were called multiple times per test, the delays were multiplied. This MR adds the memoize modifier to these calls to avoid multiple lookups of the same path.

Several extra debug messages are also added to help debug such problems in the future. The time format in the logger will now also show seconds.

Merge request reports

Pipeline #1469441 passed

Pipeline passed for 2701ef06 on rbielski:tvs-memoize-path-lookup

Merged by Frank WinklmeierFrank Winklmeier 5 years ago (Mar 9, 2020 8:14am UTC)

Merge details

  • Changes merged into master with 7d24e722.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Rafal Bielski mentioned in merge request !31073 (merged)

    mentioned in merge request !31073 (merged)

  • Rafal Bielski resolved all threads

    resolved all threads

  • Please register or sign in to reply
    Loading