TrigKernel: Mark ITrigEventLoopMgr::prepareForRun as not thread-safe.
The implementation of prepareForRun in TrigServices is marked as not thread-safe, so the interface here should be similarly marked.
Merge request reports
Activity
added Trigger master review-pending-level-1 labels
CI Result SUCCESS (hash fead390d)Athena AthSimulation externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 10590]added review-approved label and removed review-pending-level-1 label
- Resolved by Rafal Bielski
Hi @ssnyder, @fwinkl,
I don't quite follow the logic behind this? Why does the interface need this attribute? There could be multiple implementations of the same interface and only one could be "ATLAS_NOT_THREAD_SAFE". What if there are two implementations of the same interface and one is "ATLAS_THREAD_SAFE" while the other is "ATLAS_NOT_THREAD_SAFE"?Following the same logic, if I'd call a static function from
HltEventLoopMgr::nextEvent
, would Gaudi'sIEventProcessor
interface need to be marked as "ATLAS_NOT_THREAD_SAFE"?
mentioned in commit a3aafb04
added sweep:ignore label