Skip to content
Snippets Groups Projects

Fixed printing and flags behaviour after cloning

Merged Tomasz Bold requested to merge tbold/athena:fix-py3-new-jo-issues into master
All threads resolved!

The MR fixes trivial py3 print vs print(). ATR-20994 But also fixes genuine error in the behaviour of cloneAndReplace for flags. The "dynamic" flags were not cloned. As a side, I have changed the % string formatting in the flags diagnostics to the py3 compliant version.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tomasz Bold resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash b591dc2a)

    Athena AthSimulation
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 3
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11052]

  • Look good, approving --L1 (warnings are unrelated)

  • mentioned in commit 6ced8c85

  • Please register or sign in to reply
    Loading