RDO to PRD with PRD caching (CSC, MDT)

This MR follows up on MR!29397 which needed to be reverted due to failing the FrozenT0 tests. I have debugged a lot and have identified that the problems originated in two places:

1. Some updated I started making to RPC were not safe and these are removed in this MR (along with TGC, MM and sTGC as these have not been implemented yet).
2. The MDT changes required restructuring. There are two special cases 1 RDO -> 2 PRD (this was already handled in the code) and 2 RDO -> 1 PRD. The latter was using const_cast to add new data to existing collections. This cannot work in MT, so I needed to rewrite to identify special cases of 2 RDO and pass them both into the decoding code at the same time and process them together. There were edge cases which were missed : a) When RDO1 was empty, RDO 2 was unintentionally skipped b) When any RDO was empty, I was saving an empty PRD which shifted the order of PRD in the output and failed the diff-tree

These have been resolved such that my tests now align perfectly with the test before the changes were implemented. I mark this as WIP as I need to also find Savanna's update which was placed to avoid an infinite loop and was also reverted.

cc @markowen @sshaw

Thanks Ian!

The MR that fixed the infinite looping was here: !30393 (merged)

added 1 commit

• 83e09e81 - Making updates to avoid infinite loop and remove per-event warnings

Compare with previous version

resolved all threads

unmarked as a Work In Progress

changed title from WIP: RDO to PRD with PRD caching to RDO to PRD with PRD caching (CSC, MDT)

changed the description

This merge request affects 12 packages:

• MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
• MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
• MuonSpectrometer/MuonCnv/MuonMM_CnvTools
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
• MuonSpectrometer/MuonCnv/MuonRdoToPrepData
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonCnv/MuonTGC_CnvTools
• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonTrigCoinData
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

added MuonSpectrometer Trigger TriggerMenu master review-pending-level-1 labels

CI Result FAILURE (hash 83e09e81)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11071]

Jenkins please retry a build

This merge request affects 12 packages:

• MuonSpectrometer/MuonCnv/MuonCSC_CnvTools
• MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
• MuonSpectrometer/MuonCnv/MuonMM_CnvTools
• MuonSpectrometer/MuonCnv/MuonRPC_CnvTools
• MuonSpectrometer/MuonCnv/MuonRdoToPrepData
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonCnv/MuonTGC_CnvTools
• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonTrigCoinData
• Trigger/TriggerCommon/TriggerJobOpts
• Trigger/TriggerCommon/TriggerMenuMT

Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

My CI failed on a TopXAOD test in AnalysisBase. Have we always been building AnalysisBase in master? The Athena cmake warning appears to be from Rivet? Again, is not something I have been touching at all...

Ian

CI Result SUCCESS (hash 83e09e81)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11104]

Scaling to level2 for further review

added review-pending-level-2 label and removed review-pending-level-1 label