Skip to content
Snippets Groups Projects

Implementing muoncalib chains in Run-3 menu, ATR-20650

Merged Moe Wakida requested to merge mwakida/athena:Implement_muoncalib into master

I want to merge this change into master.

I implemented muoncalib chains in the Run-3 menu.

  • HLT_mu0_muoncalib_L1MU4_EMPTY for cosmic menu
  • HLT_mu0_muoncalib_L1MU20 for detector monitoring

I added an option to change the settings for these muoncalib chains to TrigHypothesis/TrigMuonHypoMT/TrigMufastHypoTool.cxx. This option only monitors variables (same as TrigHypothesis/TrigMuonHypo/TrigMufastCALHypo.cxx in Run-2 code). I also added these monitoring histograms in expert-monitoring.root.

tagging @nakahama and @sshaw for info.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • :negative_squared_cross_mark: CI Result FAILURE (hash 4c40134e)

    Athena AthSimulation AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11100]

  • Please resolve all open threads, then re-add the review-pending-level-1 label. Thanks!

    MLB (L1)

  • Moe Wakida added 1 commit

    added 1 commit

    • 7557d51b - Fix MufastHypoTool and monitoring, and update refarence

    Compare with previous version

  • This merge request affects 4 packages:

    • Trigger/TrigHypothesis/TrigMuonHypoMT
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigUpgradeTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @hartj ,@jpanduro as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 7557d51b)

    Athena AthSimulation AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11153]

  • Hi Moe,

    you will need to update the references for the tests trigAna_RDOtoRDOTrig_mt1_build and test_trig_data_v1Dev_build.py since you've added new chains (you can run the tests locally and follow the instructions for updating the references). The other test failures I think are unrelated to your changes.

    Cheers,

    Savanna

  • Moe Wakida added 71 commits

    added 71 commits

    • 7557d51b...2f5108aa - 69 commits from branch atlas:master
    • abbbc564 - Merge remote-tracking branch 'upstream/master' into Implement_muoncalib
    • 4b791e2a - Monitored all valiables and updated reference

    Compare with previous version

  • This merge request affects 5 packages:

    • Trigger/TrigHypothesis/TrigMuonHypoMT
    • Trigger/TrigValidation/TrigAnalysisTest
    • Trigger/TrigValidation/TrigUpgradeTest
    • Trigger/TrigValidation/TriggerTest
    • Trigger/TriggerCommon/TriggerMenuMT

    Adding @hartj ,@jpanduro as watchers

  • Savanna Shaw resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 4b791e2a)

    Athena AthSimulation AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11171]

  • Looks good, warning is unrelated, approving (L1)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading