Fix range errors when accessing histogram values.

Fixes occasional range errors when accessing elements of a vector when running the job mentioned in ATLASSIM-4429. Occasional NANs in verbose logs disappear. So, it likely will change the output.

This should fix invalid reads showing up in valgrind. But I did not re-run valgrind after the fix. Only checked that there are no more vector range errors in the 9 events.

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added Simulation master review-pending-level-1 labels

CI Result SUCCESS (hash cf1cd43e)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11110]

added 1 commit

• 08087f48 - Fix range errors when accessing histogram values.

Compare with previous version

The update fixes the compiler warning.

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

mentioned in merge request !31289 (merged)

CI Result SUCCESS (hash 08087f48)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11124]

Looks good to me and CI clean, approving --L1

added review-approved label and removed review-pending-level-1 label

added 1 commit

• a0b6f5d7 - Fix range errors when accessing histogram values.

Compare with previous version

Forgot to update copyright. Fixed in update above.

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

Adding @jchapman ,@pjacka ,@mfauccig ,@xiaozhon ,@ahasib ,@vpascuzz ,@tadej ,@schaarsc as watchers

added review-pending-level-1 label and removed review-approved label

CI Result FAILURE (hash a0b6f5d7)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11159]

Error in Trigger test are unrelated, this was already approved so changing labels accordingly --L1

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 1fb00027

added sweep:ignore label