tauRecTools: remove member variables in TauPi0ScoreCalculator

To calculate the BDT score, we need to provide a list of input variables. Previously, the input variables are declared as memeber variables, which make the class stateful. These member variables are now replaced with local variables.

Add a new class, i.e. BDTHelper, to help calculate the BDT score. This class is similar with TRTBDT in HelperFunction. In the future, we will remove TRTBDT.

added Reconstruction Tau master labels

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

added review-pending-level-1 label

CI Result FAILURE (hash 7c510849)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11131]

added 1 commit

• ffe95b7a - minor improvement

Compare with previous version

This merge request affects 1 package:

• Reconstruction/tauRecTools

Adding @goetz ,@martindl ,@adbailey ,@xiaozhon as watchers

Trigger_athena_data-test failed. As TauPi0ScoreCalculator is not used in online reconstruction, the failure of this test should not be related to this MR.

mentioned in merge request !31281 (merged)

CI Result FAILURE (hash ffe95b7a)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11151]

Failure is unrelated. Review can start on this one.

mentioned in merge request !31308 (merged)

resolved all threads

Looks good, although scaling to L2 for further review and final signoff given the complexity of changes

added review-pending-level-2 label and removed review-pending-level-1 label

Changes look fine, approving.

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit a2a8979f

added sweep:ignore label