Bug fix SensorSimPlanarTool.cxx

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman ,@goetz ,@battagl ,@sroe ,@stsuno as watchers

added 21.3 Digitization InnerDetector review-pending-level-1 labels

CI Result SUCCESS (hash 50f72955)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 8
For experts only: Jenkins output [CI-MERGE-REQUEST 43139]

The warnings seem unrelated to this MR, it's good to go.

MLB (L1)

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

added 1 commit

• 2bd15ea9 - Update SensorSimPlanarTool.cxx

Compare with previous version

I initializated scale_i, scale_f_e and scale_f_h to 1. so that we can skip the checks for columnwidth being 0.4 or 0.25. However, doing so, we should leave out the part with the Athena message Not column width has been found, leaving., otherwise this appears when columnWidth is 0.4 or 0.25. I debugged my code and this never happens, so I modified my commit leaving out the printout message and, as suggested, the float casting (by declaring double each variable).

I would add back a final else as otherwise the code is vulerable to some change in behaviour of p_design.widthFromColumnRange(...). You still need to avoid the float equality checks.

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman ,@goetz ,@battagl ,@sroe ,@stsuno as watchers

added review-pending-level-1 label and removed review-user-action-required label

How can I avoid the quality checks? I don't know how to implement in another way

Hi @eballabe, the 'usual' way is to implement your own equality function with a tolerance. In your case, with the numbers being close to one, this would work well. StackOverflow is your friend in this case.:-)

CI Result SUCCESS (hash 2bd15ea9)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 43175]

added review-user-action-required label and removed review-pending-level-1 label

Yeah, sorry again for missing those yesterday -- thanks for taking the time to implement the feedback from @jchapman! Please re-add the review-pending-level-1 label when the threads are resolved. It will automatically be put back after additional pushes are made, anyway.

Cheers, MLB (L1)

added 1 commit

• 69422ed9 - Update SensorSimPlanarTool.cxx

Compare with previous version

This merge request affects 1 package:

• InnerDetector/InDetDigitization/PixelRadDamDigitization

Adding @jchapman ,@goetz ,@battagl ,@sroe ,@stsuno as watchers