Corrected iteration over BS Error enums in pixels

This merge request affects 2 packages:

InnerDetector/InDetConditions/PixelConditionsTools
InnerDetector/InDetTrigRecAlgs/InDetTrigPrepRawDataFormat

Adding @goetz ,@stsuno ,@battagl ,@sroe as watchers

added InnerDetector Trigger master review-pending-level-1 labels

Was this incorrect also in Run 2 ? If so we should presumably still fix it, but would also need to check that it did not impact the processing, so it will be good to check this in the full validation.

Cheers Mark

CI Result SUCCESS (hash 9ba6d34f)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11426]

The CI looks good, and the changes look reasonable. I guess you'll follow up regarding the thread with @sutt? I will mark as review-user-action-required until it's resolved in some way ...

MLB (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi, my comment wasn't suggesting that we hold up the request - more that we approve it, but keep in mind that we have made this change for when we get the results of the full validation.

resolved all threads

Hello,

My last modification was to move Svc to Tool. So, nothing was changed in the contents itself. Since the change seems enum in IPixelByteStreamErrorsTool.h, I think it's ok.

The /src/PixelByteStreamErrorsTool.h is not thread-safe yet, which I need to work on that. When I revisit PixelByteStreamErrorsTool.h, I will certainly check this changes.

Thanks a lot, Soshi