Saving timing for all supercells

The timing cut is currently computed only for supercells with E > 50 MeV: https://gitlab.cern.ch/atlas/athena/-/blob/21.3/LArCalorimeter/LArROD/src/LArRawChannelBuilderToolOFC.cxx#L41

The default can be changed for supercells in the supercell getter. It turns out – that makes a HUGE difference in the performance when you cut on the time, as there is a significant bias toward negative ET supercells. Using gTowers as an example:

avg gTower ET: all supercells have timing = 140 MeV
avg gTower ET: only supercells with E > 50 GeV have timing = -720 MeV

added 21.3 LAr Trigger alsoTargeting:21.9 urgent labels

@damazio @viveiros @pavol @yenari @cyoung @gunal

This merge request affects 1 package:

• LArCalorimeter/LArROD

Adding @pavol as watcher

added JetEtmiss review-pending-level-1 labels

changed the description

Pavol should tell what he thinks, I believe this could be slightly problematic presenting errors of division if the energy value is close to zero.. I believe it is not a big issue, however.. Cheers, Denis

Hi Denis, Thanks for the comment. You are probably right, that for low energy supercells we will not be able to trust the timing measurement. In fact -- I'm wondering if we should consider to apply a cut on the supercell |E|, as this would give us a better timing measurement as well... but that is something we need to study. At the moment the LATOME is sensitive to all these effects, and the concern is to be able to study all of them with the simulation. Ben

I hardly believe there is anything useful to be done with the timing for an ET below 1 ADC of the Super-Cell (around 250 MeV / transverse energy) ... So, I think any cut in the simulation should be, anyway, above that (Obviously, I am only talking about timing here.. Energy might still be interesting to be known...) Denis

Yes -- that is probably true. We can study it. Also remember though, the current setup fails to compute time for all negative supercells, which is what is causing some very odd performance... so that is definitely not what we want.

CI Result SUCCESS (hash dd9a8a7a)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 11
For experts only: Jenkins output [CI-MERGE-REQUEST 43207]

Hi @bcarlson. Please can you investigate the warnings in the CI, in case they are related? In addition, it would be great to have the discussion above as a thread, so the reviewers can more easily know when it's been resolved and closed. Cheers, Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

Please switch back to 'review-pending-level-1' when you're ready. Clara (L1)

Hi @cnellist, as far as I can tell, all the warnings have to do with muons. As they are compiler warnings, and this change is only python -- I think they cannot be related to these changes.

Sorry for the above discussion not being a thread. It was a conceptual discussion that has been resolved.

Ben

added review-pending-level-1 label

removed review-user-action-required label

Wonderful! Thanks for the reply, @bcarlson. I'm happy to go ahead and approve. Clara (L1 morning follow-up)

added review-approved label and removed review-pending-level-1 label