21.9, SCT_digitization sync with master code

It ports back the most recent SCT_SurfaceChargesGenerator class from master branch. The restore old condition services is restored for 21.9 branch.

The MR is part of the preparation to implement new digi for new Strip sensor.

Test by RunUpgradeTests.py:

• The output SCT_RDOAnalysis.root from clean and patched runs are identical.
• However, there are diff output related to TrackTruthCollection See log.txt

Update: TrackTruthCollection related diff is fixed.

added 1 commit

• 63e6606b - fix trkLink broken

Compare with previous version

added 1 commit

• dd423fa8 - fix trk Truth Link broken

Compare with previous version

changed the description

unmarked as a Work In Progress

added 21.9 label

assigned to @yiliu and @nstyles

This merge request affects 1 package:

• InnerDetector/InDetDigitization/SCT_Digitization

Adding @jchapman ,@goetz ,@sroe ,@oda as watchers

added Digitization InnerDetector review-pending-level-1 labels

resolved all threads

added review-user-action-required label and removed review-pending-level-1 label

added 5 commits

• 149638df - rename member variable with prefix m_
• 4eb9ffe0 - using master SCT_SurfaceChargesGenerator (e780f49d)
• 58fa96af - adjust master dig to 21.9
• 8ed6223a - add missing configurable variable
• 9b00a6ee - fix trk Truth Link broken

Compare with previous version

marked as a Work In Progress

Moving this to WIP since there still seems to be work ongoing, and comments to address.

resolved all threads

This merge request affects 1 package:

• InnerDetector/InDetDigitization/SCT_Digitization

Adding @jchapman ,@goetz ,@sroe ,@oda as watchers

added review-pending-level-1 label and removed review-user-action-required label

Just to mention also - RunUpgradeTests.py currently only runs tests without pile-up, so it would be especially important here also to run RunTier0Tests.py too, so that we can ensure we don't break standard reconstruction and digitization including pile-up.

CI Result SUCCESS (hash dd423fa8)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST 43264]