Skip to content
Snippets Groups Projects

Added muon jet dr tool for 2D muon SFs

Merged Added muon jet dr tool for 2D muon SFs
maklein/athena:addMuonJetDrTool into 21.2
Merged Matthew Henry Klein requested to merge maklein/athena:addMuonJetDrTool into 21.2

Adds muon-jet dR decoration to be used by muon precision recs. Technically this is calculable offline, but the needs of the recs make this a little complicated (e.g. needs to use EMTopo jets without selection), so it is safer to run at DF. Scheduled in DFJets, for simplicity (avoid cyclic dependence, and running in jet code enforces that it runs after jet calibration). Let me know if someone objects.

Merge request reports

Pipeline #1527986 passed

Stage: external

Pipeline passed for d9feac8d on maklein:addMuonJetDrTool

Approval is optional

Merged by Oana Vickey BoeriuOana Vickey Boeriu 5 years ago (Apr 3, 2020 6:16am UTC)

Merge details

  • Changes merged into with f95a6974.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Matthew Henry Klein added 1 commit

    added 1 commit

    • 9bab3d64 - Added muon jet dr tool for 2D muon SFs

    Compare with previous version

  • Timo Dreyer resolved all threads

    resolved all threads

  • Timo Dreyer
    Timo Dreyer @tidreyer ·

    Passing to L2 for further review.

    Cheers, Timo (L1)

  • Timo Dreyer added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 08170b29)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :warning:
    required tests :white_check_mark:
    optional tests :cloud:

    Full details available on this CI monitor view
    :warning: AthDerivation: number of compilation errors 0, warnings 11
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 43241]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 9bab3d64)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11657]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons

    Adding @jmellent ,@nelsonc ,@ispokhar as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label

    added review-pending-level-1 label and removed review-pending-level-2 label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 9bab3d64)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :cloud:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 43246]

  • Matt LeBlanc added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Sergio Grancagnolo resolved all threads

    resolved all threads

  • Matthew Henry Klein added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons

    Adding @jmellent ,@nelsonc ,@ispokhar as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-pending-level-2 label

    added review-pending-level-1 label and removed review-pending-level-2 label

  • Sergio Grancagnolo added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • G
    Sergio Grancagnolo @grancagn ·
    Developer

    Changing labels until thread is clarified.

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f6aed407)

    AthDerivation
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    required tests :white_check_mark:
    optional tests :cloud:

    Full details available on this CI monitor view
    :white_check_mark: AthDerivation: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST 43263]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :pencil: Builds against 21.2 are performed on slc6 (for AthDerivation) and on CentOS7 (for other projects). Two result notes are posted.

    • Developers and shifters need to wait for both slc6(AthDerivation) and CentOS7(other 3 projects) results, sometimes for additional hour or two.
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash f6aed407)

    AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :warning:
    required tests :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :warning: AthAnalysis: number of compilation errors 0, warnings 7
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11702]

  • Matthew Henry Klein added changes-derivation-output review-pending-level-2 labels and removed review-user-action-required label

    added changes-derivation-output review-pending-level-2 labels and removed review-user-action-required label

  • G
    Sergio Grancagnolo @grancagn ·
    Developer

    Changes seem fine to me. Including MuonSpectrometer @rosati @nkoehler experts to have a final look for approval.

  • Sergio Grancagnolo added MuonSpectrometer review-pending-expert labels and removed review-pending-level-2 label

    added MuonSpectrometer review-pending-expert labels and removed review-pending-level-2 label

  • Nicolas Koehler
  • Nicolas Koehler
  • Nicolas Koehler
  • Nicolas Koehler added review-user-action-required label and removed review-pending-expert label

    added review-user-action-required label and removed review-pending-expert label

  • Nicolas Koehler
  • Nicolas Koehler
  • Nicolas Koehler
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Johannes Junggeburth
  • Matthew Henry Klein added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkJetEtMiss
    • PhysicsAnalysis/DerivationFramework/DerivationFrameworkMuons

    Adding @jmellent ,@nelsonc ,@ispokhar as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
    • Please register or sign in to reply