Switch to HepMcParticleLink_p3-based persistency

HepMcParticleLink_p3 uses unsigned int rather than unsigned short to hold the eventIndex. This is a step towards preventing the aliasing of higher event numbers seen with HepMcParticleLink_p2. This merge request does not change the transient HepMcParticleLink class, so it won't fix the problem on its own. The downside is that it will increase the size of events on disk. The size of this effect will need to be determined before the change is merged.

NB This will (temporarily) break the ability to read files produced in 21.9 with other branches.

FYI @nstyles, @cohm, @demers, @asalzbur

added 21.9 label

mentioned in merge request !31620 (merged)

added full-build label

unmarked as a Work In Progress

changed the description

build area is cleaned as MR is labeled as full-build

This merge request affects 16 packages:

• ForwardDetectors/LUCID/LUCID_Cnv/LUCID_EventTPCnv
• Generators/GeneratorObjects
• Generators/GeneratorObjectsTPCnv
• InnerDetector/InDetEventCnv/InDetEventAthenaPool
• InnerDetector/InDetEventCnv/InDetSimEventAthenaPool
• InnerDetector/InDetEventCnv/InDetSimEventTPCnv
• MuonSpectrometer/MuonCnv/MuonEventAthenaPool
• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonCnv/MuonSimEventAthenaPool
• MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
• Reconstruction/TrackParticleTruthAthenaPool
• Reconstruction/TrackParticleTruthTPCnv
• Tracking/TrkEventCnv/TrkTruthAthenaPool
• Tracking/TrkEventCnv/TrkTruthTPCnv
• Trigger/TrigTruthEvent/TrigTruthEventAthenaPool
• Trigger/TrigTruthEvent/TrigTruthEventTPCnv

Adding @goetz ,@rosati ,@wleight ,@sroe ,@amorley ,@nkoehler as watchers

added ForwardDetectors Generators InnerDetector MuonSpectrometer Reconstruction Simulation Tracking Trigger review-pending-level-1 labels

Thanks @jchapman - let's keep fingers crossed this goes in seamlessly.

Yes, these changes have already been used in a private 21.3 release, so hopefully. :-)

CI Result FAILURE (hash cebf305b)

	Athena
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 154
For experts only: Jenkins output [CI-MERGE-REQUEST 43242]

SimulationTier0Test fails as expected due to the changed persistent versions. I can update it as part of the MR or do it after the next nightly after this MR has been merged.

Thanks @jchapman - the next build will be on Wednesday night, so I will merge this on Wednesday evening all being well, to avoid inconsistencies between the content of the git repo and the cvmfs release in the meantime.

Sounds good @nstyles

Going to bump this up to L2, as the CI looks as expected given what @jchapman said above ...

MLB (L1)

added review-pending-level-2 label and removed review-pending-level-1 label

To review this MR, I tried to compare files version p3 vs p2, and in general the added new version p(n+1) vs p(n). I did not do for all files, but minimal incremental changes are fine for those I checked.

Copyrights for new files could be set at 2020, but this is not an issue preventing to approve.

added review-approved label and removed review-pending-level-2 label

Thanks @grancagn - we already discussed that copyright updates could be done in a later MR once we have seen that these and subsequent changes have the desired impact on truth links.

mentioned in commit a7e55cb7

merged

mentioned in merge request !31635 (merged)

mentioned in merge request !31687 (merged)

added sweep:ignore label

mentioned in merge request !31624 (merged)

mentioned in commit fc60139a

mentioned in merge request !31717 (merged)

mentioned in commit c1a6d018