Modifying precisionElectronHypo so it can explicitly pass event context explicitly

In the precisionElectronHypo where we use likelihood selection, we need to calculate and monitor some variables with IAsgElectronLikelihoodTool.h which needs explicit passing of event context e.g. https://gitlab.cern.ch/atlas/athena/-/blob/master/PhysicsAnalysis/Interfaces/EgammaAnalysisInterfaces/EgammaAnalysisInterfaces/IAsgElectronLikelihoodTool.h#L53 . With this MR I am enabling current precisionElectronHypo to pass event context. Would like to know if I am doing it right way although it passes all the tests. Adding @tamartin , @fernando also @christos .

Looks fine, though you might trigger a compile warning from not actually using it. Just put bool TrigEgammaPrecisionElectronHypoToolInc::decide( const ITrigEgammaPrecisionElectronHypoTool::ElectronInfo& input,const EventContext&) const { if that's the case, util you need to use it.

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigEgammaHypo

added Egamma Trigger master review-pending-level-1 labels

added 1 commit

• efa289fb - removing currently unused context to avoid warning

Compare with previous version

This merge request affects 1 package:

• Trigger/TrigHypothesis/TrigEgammaHypo

CI Result SUCCESS (hash 50372fc1)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11658]

CI Result SUCCESS (hash efa289fb)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11670]

The warning is not from my changes right??

@dbakshig that's right, the warnings don't come from this MR.

Let me know about the debug lines, if they're intended to remain this can probably move ahead ...

MLB (L1)

Hi @mleblanc ,

Thanks for noticing actually I would like to keep const int cutIndex = findCutIndex( absEta ); Let me push the changes.

Thanks, Debo.

Hi @mleblanc ,

Apologies I misunderstood please go ahead with the MR those debug lines were there all along. I don't think it hurts.

Thanks, Debo.

resolved all threads

OK, sounds good. I think this can go forward then ...

MLB (L1)

added review-approved label and removed review-pending-level-1 label

Sure Thanks, Debo.

merged

mentioned in commit 8b52aabf

added sweep:ignore label