Skip to content
Snippets Groups Projects

auto_ptr to unique_ptr (7) ATLASRECTS-5296

Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:auto_to_unique into master
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Hi @christos

    I have one comment related to the commented code. Could you have a look ?

    Thanks.

    Xiaozhong (L1)

  • added 1 commit

    Compare with previous version

  • This merge request affects 33 packages. Since this is a long list, I will not print it here.

    Adding @goetz ,@harkusha ,@cohm ,@krumnack ,@maklein ,@solodkov ,@szambito ,@ykeisuke ,@jojungge ,@yoyamagu ,@rbielski ,@ggach ,@zmarshal ,@fsforza ,@pavol ,@oducu ,@mnowak ,@ssnyder ,@oabouzei ,@kwhalen ,@mhodgkin ,@nkoehler ,@afaulkne ,@gartoni ,@rbianchi as watchers

  • Xiaozhong Huang resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 119e60c6)

    Athena AthSimulation AnalysisBase
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11817]

  • The changes look good, and CI passes. Approving.

    Xiaozhong (L1)

  • merged

  • Walter Lampl mentioned in commit cbad5fe4

    mentioned in commit cbad5fe4

  • Please register or sign in to reply
    Loading