Clang warning on IRegSelLUT

Try to fix warnings of the form

cvmfs/sft.cern.ch/lcg/releases/gcc/9.2.0-afc57/x86_64-centos7/lib/gcc/x86_64-pc-linux-gnu/9.2.0/../../../../include/c++/9.2.0/bits/unique_ptr.h:81:2: warning: delete called on 'IRegSelLUT' that is abstract but has non-virtual destructor [-Wdelete-abstract-non-virtual-dtor]
        delete __ptr;

Also used a bit nullptr and emplace_back where applicable.

This merge request affects 3 packages:

• DetectorDescription/IRegionSelector
• DetectorDescription/RegSelLUT
• DetectorDescription/RegionSelector

Adding @sutt ,@nkoehler ,@rbianchi as watchers

added Geometry Trigger master review-pending-level-1 labels

Hi, not that I mind the changes, but the plan is to remove this RegSelSvc class as soon as we have migrated to use the RegSelTool class, so there's probably no point doing anything to the RegSelSvc after this.

Cheers Mark

CI Result SUCCESS (hash 8ed72557)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 2
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11770]

mentioned in merge request !31692 (closed)

Hi @christos,

I have some comments related to the style, could you have a look ? The other changes look really nice.

Thanks.

Xiaozhong (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• feb7ff3c - style ? requests

Compare with previous version

resolved all threads

Jenkins please retry a build

This merge request affects 3 packages:

• DetectorDescription/IRegionSelector
• DetectorDescription/RegSelLUT
• DetectorDescription/RegionSelector

Adding @sutt ,@nkoehler ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

Considering the last commit is very simple, and the previous CI passes. I would like to approve this MR.

Xiaozhong (L1)

added review-approved label and removed review-pending-level-1 label

resolved all threads

CI Result SUCCESS (hash feb7ff3c)

	Athena	AthSimulation	AnalysisBase
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11805]

merged

mentioned in commit 7d9343ee