Skip to content
Snippets Groups Projects

xAODDataSource: Fix test failures.

Merged Scott Snyder requested to merge ssnyder/athena:test.xAODDataSource-20200403 into master
1 unresolved thread

Additional patterns to ignore to fix test failures in master. Also, be more specific in suppressing ubsan warnings.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
30 31 atlas_add_test( dataSourceEvent_test
31 32 SOURCES test/dataSourceEvent_test.cxx
32 33 INCLUDE_DIRS ${ROOT_INCLUDE_DIRS}
33 LINK_LIBRARIES ${ROOT_LIBRARIES} xAODRootAccess xAODDataSourceLib )
34 LINK_LIBRARIES ${ROOT_LIBRARIES} xAODRootAccess xAODDataSourceLib
35 LOG_IGNORE_PATTERN "Can.t find BranchInfo|Function should only be called" )
  • I am not a fan of this at all... :frowning: In my book these warnings show an error in our code. They should not be ignored!

  • So @fwinkl, I guess I'll be fixing this in another way in the next days... :thinking:

  • Either way is fine with me. I am also happy to revert this again if you prefer.

  • Parts of it are fine. The suppression of the undefined behaviour sanitiser is fine. It is just that these warnings appeared from xAODRootAccess because of a change in the behaviour of StoreGate. Which I don't want to "solve" by introducing suppression rules in all unit tests that use xAOD::TEvent... (Plus, printing warnings every time a user reads a DxAOD like that, is really not a good thing...)

  • Please register or sign in to reply
  • Please register or sign in to reply
    Loading