Skip to content
Snippets Groups Projects

Add muonagdd option to dump-geo

Merged Nicolas Koehler requested to merge nkoehler/athena:vp1Dbg into master
All threads resolved!

Hi,

this MR adds an -muonagdd option to dump-geo to read local xml files.

Best, Nico

Edited by Nicolas Koehler

Merge request reports

Pipeline #1562134 passed

Pipeline passed for 82eb2b75 on nkoehler:vp1Dbg

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Apr 16, 2020 11:27am UTC)

Merge details

  • Changes merged into master with 3f866522.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 925b49fd - use python3 compatible printing

    Compare with previous version

  • Nicolas Koehler resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
    • graphics/VP1/VP1Algs

    Adding @nkoehler ,@rbianchi as watchers

  • :white_check_mark: CI Result SUCCESS (hash 925b49fd)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11980]

  • This looks OK.

    MLB (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Hi @nkoehler,

    unfortunalty this MR has picked up a merge conflict.

    • Walter
  • The philosopher of the day for @goblirsc

    image

  • Nicolas Koehler added 551 commits

    added 551 commits

    Compare with previous version

  • Nicolas Koehler changed title from Print AGDD xml filelist in VP1 and dump-geo to Add muonagdd option to dump-geo

    changed title from Print AGDD xml filelist in VP1 and dump-geo to Add muonagdd option to dump-geo

  • Nicolas Koehler changed the description

    changed the description

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo

    Adding @nkoehler ,@rbianchi as watchers

  • This merge request affects 1 package:

    • DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo

    Adding @nkoehler ,@rbianchi as watchers

  • :white_check_mark: CI Result SUCCESS (hash c09db122)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12367]

  • :white_check_mark: CI Result SUCCESS (hash 82eb2b75)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12368]

  • Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 3f866522

  • Please register or sign in to reply
    Loading