Fix 'dump-geo' in master
dump-geo
is now broken in Athena,master
.
This fixes the check of input of custom NSW AGDD files, by replacing the test over a variable to one over an empty string.
This MR fixes ATLASDD-39.
This MR adds changes from @rbianchi and @nkoehler .
This MR includes and supersedes MR !31776 (merged) .
Merge request reports
Activity
This MR includes and supersedes MR !31776 (merged) .
added EventDisplay Geometry master review-pending-level-1 labels
removed EventDisplay Geometry master review-pending-level-1 labels
Jenkins please retry a build
Edited by Riccardo Maria BianchiThe pipeline continues to fail at the very beginning, in the Jenkins step itself.
I checked the log and I found this:
15:33:06 “Info: looking for big files in /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master” 15:33:06 “Warning: JENKINS DETERMINED THAT THE BUILD JOB FOR MR ID 244381, HASH 3334f42e OS CentOS IS ALREADY RUNNING” 15:33:06 “Info: JOB IS RECOGNIZED AS DUPLICATE AND THEREFORE STOPPED” 15:33:06 Build step 'Execute shell' marked build as failure 15:33:07 Finished: FAILURE
@aundrus , @akraszna , @fwinkl , sorry to summon you, but I wanted to ask you if you have any idea how can we fix that. It does not seem we have duplicate runs of this MR, at least from what I see here. Thanks a lot for your kind help.
Best, -- Ric.
Hi @rbianchi, the job that was triggered for the MR creation is currently running: https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-CC7/11891/
All retries are automatically cancelled as they are recognized as duplicate jobs. The question is if the running job is OK (in sense that it checks all commits) or you need to restart it?
Alex
Edited by Alexander UndrusHi @aundrus , Thanks for the explanation.
What I don’t understand is why it says pipeline failed if it’s already running. Should it show the “pipeline is running” status and the blue running icon?
Anyway, The MR is ok, all commits have been taken. So, does it mean that the current running pipeline will continue to run until the end and then the status will be updated automatically and the “failed” flag removed?
Thanks again for your help, — Ric.
Hi @rbianchi, unfortunately the pipeline status is not 100% reliable indicator. It is long standing issue, e.g.: https://its.cern.ch/jira/browse/ATLINFR-2000, https://its.cern.ch/jira/browse/ATLINFR-2666.
The origins of issues are Jenkins gitlab plugin bugs and problems in communication between gitlab and Jenkins. As discussed at the last S&C week, we aim to replace Jenkins with GitLab CI (rather then contributing to Jenkins development)
Alex
Edited by Alexander Undrus CI Result SUCCESS (hash 3334f42e)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 5
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 11891]Hi @tsulaia and @emoyse, might I ask you to merge this? It's not affecting any other Athena code since it is only about the command-line options of
dump-geo
andvp1
.Also, I checked the CI output: the warnings in the Athena project build are not related to this MR: they are all about thread-safeness and in packages not touched by this MR. They should be addressed in a separate MR.
But I understand of course if you want to wait the L1 and L2 check.
Thanks a lot, and have a good day, -- Ric.
Hi Ric, I think this week @wlampl is coordinating master release.
mentioned in commit 4cce46ad