Disable StatusCodeSvc

StatusCodeSvc is deprecated and replaced by compile-time checks (see https://indico.cern.ch/event/904771):

• Remove all references to StatusCodeSvc from job options
• Remove RecFlags.abortOnUncheckedStatusCode and all references to it
• Ignore any StatusCodeSvc related lines in log file comparison script
• Update bootstrap.pkl files to reflect the change in default services

added full-unit-tests label

This merge request affects 29 packages. Since this is a long list, I will not print it here.

Adding @jchapman ,@rosati ,@kwhalen ,@khamano ,@wiedenma ,@solodkov ,@bernius ,@jajimene ,@fwinkl ,@jpanduro ,@nkoehler ,@afaulkne ,@goetz ,@wleight ,@pavol ,@martis ,@sroe ,@harkusha ,@ssnyder ,@hartj ,@ggallard ,@vpascuzz ,@rbielski ,@rbianchi as watchers

added Analysis Core Egamma EventDisplay ForwardDetectors Geometry InnerDetector JetEtmiss MuonSpectrometer Reconstruction Simulation Test Tile Trigger master review-pending-level-1 labels

CI Result FAILURE (hash bc0f3536)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12012]

Unrelated test failure in Digitization_test_MC16a_Digi_tf_configuration_ctest. The same test fails in the nightly build.

Hi @fwinkl,

!31796 (merged) fixes that unit test failure if you want to get rid of the annoying warning. :-)

Cheers,

John

31796 has been merged. Let's retry a build to make sure.

Xiaozhong (L1)

Jenkins please retry a build

This merge request affects 29 packages. Since this is a long list, I will not print it here.

Adding @jchapman ,@rosati ,@kwhalen ,@khamano ,@wiedenma ,@solodkov ,@bernius ,@jajimene ,@fwinkl ,@jpanduro ,@nkoehler ,@afaulkne ,@goetz ,@wleight ,@pavol ,@martis ,@sroe ,@harkusha ,@ssnyder ,@hartj ,@ggallard ,@vpascuzz ,@rbielski ,@rbianchi as watchers

CI Result FAILURE (hash bc0f3536)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12126]

Hi @fwinkl,

Several unit-tests failed. See below

1. TrigL2MuonSA_MdtDataPreparator_test_ctest and MuonConfig_MdtRdoToPrepDataTool_test_ctest

AtlasFieldSvc ERROR Missing solenoid current in DCS information AtlasFieldSvc ERROR Missing toroid current in DCS information IOVSvc.IOVSvcTool ERROR Problems calling IOVSvc.IOVSvcTool ERROR Problems preloading IOVRanges IncidentSvc ERROR Standard std::exception is caught handling incident BeginRun IncidentSvc ERROR IOVSvcTool::preLoadProxies 2020-Apr-10 05:45:03,038 FATAL [static void ers::ErrorHandler::terminate_handler() at /builds/atlas-tdaq-software/tdaq-cmake/tdaq-common/tdaq-common-03-04-01/ers/src/ErrorHandler.cxx:129] Unhandled 'std::exception' exception was thrown

2. MuonConfig_MdtIntersectGeometry_test_ctest

AtlasFieldCache... ERROR UpdateCurrentFromConditions: Missing solenoid current in DCS information AtlasFieldCache... ERROR UpdateCurrentFromConditions: Missing toroid current in DCS information AtlasFieldCache... ERROR MagFieldServices/src/AtlasFieldCacheCondAlg.cxx:92 (StatusCode MagField::AtlasFieldCacheCondAlg::execute(const EventContext&) const): code FAILURE: updateCurrentFromConditions(ctx, cache)

3. TrkVertexFitterUtils_ImpactPoint3dEstimator_test_ctest

ServiceManager FATAL No Service factory for ConditionStore available. VarHandleKey.Se... ERROR ServiceLocatorHelper::service: can not locate service ConditionStore ERROR StoreGate/src/VarHandleKey.cxx:129 (StatusCode SG::VarHandleKey::initialize(bool)): code FAILURE: Cannot locate store: ConditionStore ToolSvc.Default... ERROR TrkExRungeKuttaPropagator/src/RungeKuttaPropagator.cxx:57 (StatusCode Trk::RungeKuttaPropagator::initialize()): code FAILURE: m_fieldCondObjInputKey.initialize(m_useCondObj)

4. TrkVertexSeedFinderUtils_NewtonTrkDistanceFinder_test_ctest

ERROR: NewtonTrkDistanceFinder_test.log and ../share/NewtonTrkDistanceFinder_test.ref differ

5. TrkVertexSeedFinderUtils_Trk2dDistanceSeeder_test_ctest

ERROR: Trk2dDistanceSeeder_test.log and ../share/Trk2dDistanceSeeder_test.ref differ

6. TrkVertexSeedFinderUtils_SeedNewtonTrkDistanceFinder_test_ctest

ERROR: SeedNewtonTrkDistanceFinder_test.log and ../share/SeedNewtonTrkDistanceFinder_test.ref differ

7. TrkVertexSeedFinderUtils_Trk2DDistanceFinder_test_ctest

ERROR: Trk2DDistanceFinder_test.log and ../share/Trk2DDistanceFinder_test.ref differ

8. FastCaloSim_FastShowerCellBuilderTool_test_ctest

ERROR: FastShowerCellBuilderTool_test.log and ../share/FastShowerCellBuilderTool_test.ref differ

Could you have a look ?

Thanks.

Xiaozhong (L1)

added review-user-action-required label and removed review-pending-level-1 label

The same tests fail in our full nightly build: https://bigpanda.cern.ch/testsview/?nightly=master_Athena_x86_64-centos7-gcc8-opt&rel=2020-04-09T2140&ar=x86_64-centos7-gcc8-opt&proj=Athena

So this is unrelated to the MR here. You can continue with the review.

added review-pending-level-1 label and removed review-user-action-required label

Thanks. Changes look fine to me. Approving now.

Xiaozhong (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 94552250

added sweep:ignore label