Skip to content
Snippets Groups Projects

AthenaKernel+TrigNavTools+xAODTriggerAthenaPool: Move ITrigNavigationThinningSvc.

Merged AthenaKernel+TrigNavTools+xAODTriggerAthenaPool: Move ITrigNavigationThinningSvc.
ssnyder/athena:navthinning2.AthenaKernel-20200411 into master
All threads resolved!
Merged Scott Snyder requested to merge ssnyder/athena:navthinning2.AthenaKernel-20200411 into master
All threads resolved!

Move ITrigNavigationThinningSvc here from TrigNavTools to AthenaKernel, modernizing it. Extend ThinningCache to hold a pointer to this interface.

Merge request reports

Pipeline #1553904 passed

Stage: external

Pipeline passed for 02cc6c88 on ssnyder:navthinning2.AthenaKernel-20200411

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 5 years ago (Apr 14, 2020 10:09am UTC)

Merge details

  • Changes merged into master with 23d8e5d2.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Scott Snyder added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Control/AthenaKernel
    • Event/xAOD/xAODTriggerAthenaPool
    • Trigger/TrigEvent/TrigNavTools

    Adding @tamartin ,@akraszna ,@ssnyder as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 02cc6c88)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12181]

  • Edson Carquin Lopez
    Edson Carquin Lopez @carquin ·
    Developer

    Looks good, scaling to L2 for further review and final sign off, also please resolve open threads

  • Edson Carquin Lopez added review-pending-level-2 label and removed review-pending-level-1 label

    added review-pending-level-2 label and removed review-pending-level-1 label

  • Pavol Strizenec
    Pavol Strizenec @pavol ·
    Developer

    Changes looks fine, @ssnyder could you comment Attila question ?

    Thanks, Pavol [as L2 MR shifter]

  • Pavol Strizenec added review-user-action-required label

    added review-user-action-required label

  • Scott Snyder resolved all threads

    resolved all threads

  • Attila Krasznahorkay added review-approved label and removed review-pending-level-2 review-user-action-required labels

    added review-approved label and removed review-pending-level-2 review-user-action-required labels

  • Attila Krasznahorkay
    Attila Krasznahorkay @akraszna ·
    Maintainer

    :thumbsup:

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit 23d8e5d2

    mentioned in commit 23d8e5d2

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply