Migration of the remaining Generator packages to AtlasHepMC
Migration of the remaining Generator packages to AtlasHepMC, implementing the suggestions from @jchapman from !31532 (merged)
Merge request reports
Activity
This merge request affects 14 packages:
- Event/xAOD/xAODTruthCnv
- Generators/AtlasHepMC
- Generators/Epos_i
- Generators/GenAnalysisTools/TruthHelper
- Generators/GenInterfaces
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- Generators/GenzModuleEvent
- Generators/HepMCAnalysis_i
- Generators/QGSJet_i
- Generators/Sherpa_i
- Generators/TruthIO
- PhysicsAnalysis/TruthParticleID/McParticleEvent
- Reconstruction/MissingETEvent
added Analysis EDM Generators JetEtmiss Reconstruction master review-pending-level-1 labels
added 4 commits
-
ce906c1e...a5b6349c - 3 commits from branch
atlas:master
- fd8f86ef - Merge remote-tracking branch 'upstream/master' into HepMC3part1p6AtlasHepMC
-
ce906c1e...a5b6349c - 3 commits from branch
This merge request affects 14 packages:
- Event/xAOD/xAODTruthCnv
- Generators/AtlasHepMC
- Generators/Epos_i
- Generators/GenAnalysisTools/TruthHelper
- Generators/GenInterfaces
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- Generators/GenzModuleEvent
- Generators/HepMCAnalysis_i
- Generators/QGSJet_i
- Generators/Sherpa_i
- Generators/TruthIO
- PhysicsAnalysis/TruthParticleID/McParticleEvent
- Reconstruction/MissingETEvent
CI Result SUCCESS (hash fd8f86ef)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12189]added review-approved label and removed review-pending-level-1 label
added review-pending-expert label and removed review-approved label
added 227 commits
-
fd8f86ef...25cccb54 - 226 commits from branch
atlas:master
- cfdae175 - Merge remote-tracking branch 'upstream/master' into HepMC3part1p6AtlasHepMC
-
fd8f86ef...25cccb54 - 226 commits from branch
This merge request affects 14 packages:
- Event/xAOD/xAODTruthCnv
- Generators/AtlasHepMC
- Generators/Epos_i
- Generators/GenAnalysisTools/TruthHelper
- Generators/GenInterfaces
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- Generators/GenzModuleEvent
- Generators/HepMCAnalysis_i
- Generators/QGSJet_i
- Generators/Sherpa_i
- Generators/TruthIO
- PhysicsAnalysis/TruthParticleID/McParticleEvent
- Reconstruction/MissingETEvent
added review-pending-level-1 label and removed review-pending-expert label
CI Result SUCCESS (hash cfdae175)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12386]Changing label back to review-pending-expert. Clara (L1)
added review-pending-expert label and removed review-pending-level-1 label
- Resolved by Clara Nellist
Hi @cnellist , yes, I'm waiting for Attila or Frank as the changes are related to cmake. Concerning the review, there are no changes since the approval by @pavol . The only thing I did was is the merge of the recent commits from master. But it would be nice it you could approve it as well.
Thank you Andrii
- Resolved by Clara Nellist
Hi @cnellist , it is always good at least to inform them, but if they are busy, we can proceed. These changes were discussed many times and are the same as implemented in some earlier merge requests.
Best regards
Andrii
added review-pending-level-1 label and removed review-pending-expert label
This was already approved by @pavol and CI is clean (known issue with CMake warnings), changing labels according
added review-approved label and removed review-pending-level-1 label
mentioned in commit 60ef048f
added sweep:ignore label