Cmake fixes in MCP packages
Hi,
this MR adds the StoreGate
to the CMakeLists.txt
of the MCP packages since it is needed for ReadHandles
but was not part of the CMakeLists.txt
so far. This adaption is only needed for master, thus, no sweep labels.
Also added some ReadHandles to athena algs which did not use them yet.
Best, Nico
Merge request reports
Activity
This merge request affects 3 packages:
- PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
- PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
- PhysicsAnalysis/MuonID/MuonSelectorTools
Adding @fsforza ,@nakahama ,@szambito ,@jojungge ,@markowen ,@gabarone ,@nkoehler ,@gartoni as watchers
added Analysis master review-pending-level-1 labels
CI Result SUCCESS (hash 06e12d74)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12201]The CI looks good and the changes look straightforward, I think this can go ahead unless @akraszna has feedback about the CMakeLists changes.
MLB (L1)
added review-approved label and removed review-pending-level-1 label
- Resolved by Nicolas Koehler
- Resolved by Nicolas Koehler
- Resolved by Nicolas Koehler
added review-user-action-required label and removed review-approved label
added 118 commits
-
06e12d74...fcf8950a - 116 commits from branch
atlas:master
- 6ae80cdf - Merge branch 'master' of ssh://gitlab.cern.ch:7999/atlas/athena into mcpCmake
- bfa981d1 - make StoreGate depedency public
-
06e12d74...fcf8950a - 116 commits from branch
This merge request affects 3 packages:
- PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
- PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
- PhysicsAnalysis/MuonID/MuonSelectorTools
Adding @fsforza ,@nakahama ,@szambito ,@jojungge ,@markowen ,@gabarone ,@nkoehler ,@gartoni as watchers
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash bfa981d1)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12268]added review-approved label and removed review-pending-level-1 label
mentioned in commit 22f62c84
added sweep:ignore label