Skip to content
Snippets Groups Projects

Cmake fixes in MCP packages

Merged Nicolas Koehler requested to merge nkoehler/athena:mcpCmake into master
All threads resolved!

Hi,

this MR adds the StoreGate to the CMakeLists.txt of the MCP packages since it is needed for ReadHandles but was not part of the CMakeLists.txt so far. This adaption is only needed for master, thus, no sweep labels. Also added some ReadHandles to athena algs which did not use them yet.

Best, Nico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Nicolas Koehler added 118 commits

    added 118 commits

    Compare with previous version

  • Nicolas Koehler resolved all threads

    resolved all threads

  • This merge request affects 3 packages:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonEfficiencyCorrections
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections
    • PhysicsAnalysis/MuonID/MuonSelectorTools

    Adding @fsforza ,@nakahama ,@szambito ,@jojungge ,@markowen ,@gabarone ,@nkoehler ,@gartoni as watchers

  • :white_check_mark: CI Result SUCCESS (hash bfa981d1)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12268]

  • This MR was already approved so changing back labels accordingly --L1

  • mentioned in commit 22f62c84

  • Please register or sign in to reply
    Loading