Skip to content
Snippets Groups Projects

cherry-pick PATInterfaces package from 21.2

All threads resolved!

Pretty straight-forward cherry-pick, plus adding the package to AnalysisBase.

Turns out the main difference were updates to copyrights, but some code changes were done as well.

List of commits involved:

  • a64076b3 Fixing the package's build in standalone mode with CMake (PATInterfaces-00-00-35)
  • afec45c1 Updated to PATInterfaces-00-00-38.
  • c410de54 added test for SystematicSet clearing
  • 9b309e93 Fixed SystematicSet clear behavior.
  • a580600d boost::unordered_map --> std::unordered_map : ROOT-8890
  • 54078d0b replace ISU copyright with CERN copyright
  • ffdb051f make sure an empty string translates to an empty SystematicSet
Edited by Nils Erik Krumnack

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks good in general, just waiting for the CI to finish

  • Edson Carquin Lopez resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 1774a7b0)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12285]

  • Warning is unrelated to the changes in this MR.

  • Looks good, approving --L1

  • mentioned in commit b5139f85

  • Please register or sign in to reply
    Loading