cherry-pick PATCore package from 21.2

Simple and straightforward cherry-pick, plus activating the package in AnalysisBase.

And yes, I'm aware that we will have a merge conflict with multiple MRs modifying the package_filters.txt, but I'd rather fix this up as it occurs instead of waiting full cycle with each update before moving to the next package.

mentioned in merge request !31948 (merged)

Hi,

I think RootCore/Packages.h also needs to be removed from PhysicsAnalysis/AnalysisCommon/PATCore/PATCore/TSelectorToolBase.h to pass the compilation of AnalysisBase.

Best, Nico

This merge request affects 2 packages:

• PhysicsAnalysis/AnalysisCommon/PATCore
• Projects/AnalysisBase

Adding @krumnack ,@akraszna ,@rbianchi as watchers

added Analysis Build master review-pending-level-1 labels

added 1 commit

• 0bba03b6 - remove TSelectorToolBase class

Compare with previous version

So turned out I test-compiled without re-running cmake...

Now TSelectorToolBase failed the compilation so I completely removed it (I don't believe there are any users in the repository. Also allowed me to remove the "CINT" dictionary from the package.

This merge request affects 2 packages:

• PhysicsAnalysis/AnalysisCommon/PATCore
• Projects/AnalysisBase

Adding @krumnack ,@akraszna ,@rbianchi as watchers

CI Result FAILURE (hash aa747c84)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12289]

CI Result SUCCESS (hash 0bba03b6)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 1
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12296]

added 2 commits

• f77bde61 - make separate dictionary for Athena
• 8916b62d - remove old cmt directory

Compare with previous version

I think I understood the warning and it should be fixed by splitting off the dictionary. Also did a bit more house-keeping by cleaning up the old cmt directory.

This merge request affects 2 packages:

• PhysicsAnalysis/AnalysisCommon/PATCore
• Projects/AnalysisBase

Adding @krumnack ,@akraszna ,@rbianchi as watchers

CI Result SUCCESS (hash 8916b62d)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12319]

added 111 commits

• 8916b62d...b5139f85 - 106 commits from branch atlas:master
• c356f71b - Updated to PATCore-00-00-26.
• 829e73f9 - add PATCore package to AnalysisBase
• 0944baeb - remove TSelectorToolBase class
• 8bc2f748 - make separate dictionary for Athena
• 74c397b4 - remove old cmt directory

Compare with previous version

The anticipated merge conflict came, and this should resolve it.

This merge request affects 2 packages:

• PhysicsAnalysis/AnalysisCommon/PATCore
• Projects/AnalysisBase

Adding @krumnack ,@akraszna ,@rbianchi as watchers

CI Result SUCCESS (hash 74c397b4)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12364]

Looks good, CI clean, approving --L1

added review-approved label and removed review-pending-level-1 label

mentioned in commit 107dbdbc