Skip to content
Snippets Groups Projects

Configuration of a new offline monitoring tool for trigger jets

First and very basic version of a configuration of the offline jet monitoring tool for trigger jets. To be used for Run 2 and Run 3 HLT chains/jets.

A small addition was added to the offline monitoring tool to be able to have Et histograms.

There are a lot of comments which will be removed in a more mature version (current comments will be helpful to extend it shortly).

@khoo @delsart @wobisch

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Looks fine to me, though it would be great if the copyright statements could be updated. Sending to L2 for a second opinion. Clara (L1)

  • added 1 commit

    Compare with previous version

  • Jonathan Bossio resolved all threads

    resolved all threads

  • This merge request affects 2 packages:

    • Reconstruction/Jet/JetMonitoring
    • Trigger/TrigMonitoring/TrigJetMonitoring

    Adding @goetz as watcher

  • added 1 commit

    • 0bf6888d - Follow naming convention for new MT monitoring

    Compare with previous version

  • This merge request affects 2 packages:

    • Reconstruction/Jet/JetMonitoring
    • Trigger/TrigMonitoring/TrigJetMonitoring

    Adding @goetz as watcher

  • :white_check_mark: CI Result SUCCESS (hash 074db71c)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12340]

  • :white_check_mark: CI Result SUCCESS (hash 0bf6888d)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12342]

  • Sending back to L2 for second opinion. Clara (L1)

  • Joseph Haley
  • The method Variable::create(...) creates new objects on the heap and returns a raw pointer, which should be changed to a unique_ptr per ATLAS guidelines, but I think that is not really in the scope of this MR. So I will mark this MR as approved, but the authors should make a new MR to change the raw pointers to smart pointers. ~Joe (L2)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading