Skip to content
Snippets Groups Projects

MET mon legacy monitoring update

Merged Kenji Hamano requested to merge khamano/athena:MetMonUpdate_apr2020 into master

Met legacy monitoring update. Folder structure and selection of histograms simplified. Chain specific MET used the chain specific algorithm.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jon Burr
  • Jon Burr
  • Changing label to review-user-action-required until the discussions are resolved. Clara (L1)

  • Kenji Hamano added 1 commit

    added 1 commit

    • 9bbc1601 - removed commented lines from TrigMETMonitCategory.py

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigMonitoring/TrigMETMonitoring

    Adding @khamano ,@ggallard as watchers

  • Kenji Hamano resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 9bbc1601)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :cloud: :cloud: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12341]

  • Looks fine to me. Two minor questions about commented lines. Sending to L2 for a second opinion. Clara (L1)

  • Kenji Hamano added 1 commit

    added 1 commit

    • 808850d6 - Commented code removed in HLTMETMonTool.cxx

    Compare with previous version

  • Clara Nellist resolved all threads

    resolved all threads

  • This merge request affects 1 package:

    • Trigger/TrigMonitoring/TrigMETMonitoring

    Adding @khamano ,@ggallard as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading