XMLDumperFromAthena Follow-Up, master branch (2020.04.19.)

This is a follow-up from !32066 (merged) and !32144 (merged).

Added back some error checking to the script. Otherwise the nightly and CI are blind to errors coming from this code... In the end that's why I added set -e to the script in !32066 (merged) in the first place. As I noticed that in my local builds, where EOS was not available, and hence the script could not succeed, the CMake build still treated the build as a success. Which is really not ideal.

The heart of the problem was that the script never did anything with its ${athena_exit} variable. Even though it was clearly set up to be the return value of the script. So I now made it so.

Also, the reason that the CI didn't reveal any problems in !32066 (merged) was that in incremental builds the trigger menu is not re-generated. So the CI of that job didn't actually test my code changes. Because of this I've added the full-build tag to this MR...

Pinging @wlampl, @fwinkl and @rbielski.

added full-build label

build area is cleaned as MR is labeled as full-build

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuXML

added Trigger TriggerMenu master review-pending-level-1 labels

I know it's not a big issue, but it was a bit annoying to find out that TriggerMenuXML can only build successfully if TriggerMenu is also "checked-out". In partial checkouts this is a bit annoying... But not sufficiently that I would've wanted to do anything about it. (The package's CMake configuration could be made a little smarter to deal with that case as well...)

Hi @akraszna,

I though it was on purpose not to return the athena exit code. There is a comment line at the end of the script saying it should always succeed. Trigger experts should clarify ...

• Walter

CI Result SUCCESS (hash cdffa91b)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12547]

This looks good to me. Not much point in spending more time on this as most of this package will become obsolete once we remove the Run-2 trigger from master.

Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit 07749653

merged

added sweep:ignore label