Skip to content

XMLDumperFromAthena Follow-Up, master branch (2020.04.19.)

This is a follow-up from !32066 (merged) and !32144 (merged).

Added back some error checking to the script. Otherwise the nightly and CI are blind to errors coming from this code... In the end that's why I added set -e to the script in !32066 (merged) in the first place. As I noticed that in my local builds, where EOS was not available, and hence the script could not succeed, the CMake build still treated the build as a success. Which is really not ideal.

The heart of the problem was that the script never did anything with its ${athena_exit} variable. Even though it was clearly set up to be the return value of the script. So I now made it so. 😛

Also, the reason that the CI didn't reveal any problems in !32066 (merged) was that in incremental builds the trigger menu is not re-generated. So the CI of that job didn't actually test my code changes. Because of this I've added the full-build tag to this MR...

Pinging @wlampl, @fwinkl and @rbielski.

Merge request reports