add CalibHitToCaloCellTool

This tool is needed for making Derivations work in master as it is used by DerivationFrameworkEgamma

@jcatmore

added master label

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

added Calorimeter JetEtmiss review-pending-level-1 labels

mentioned in merge request !32307 (merged)

added 1 commit

• f543a1c9 - make const-compatible

Compare with previous version

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

I changed the interface to be make it possible to call the tool const. A bunch of member variables weren't really needed

OK I recall when this was used.

@inomidis think developed it and should be used to create "true" clusters for specific workflows.

Depending on the plans we will need also to change the retrieval and Finalize clusters if we are to run with the scheduler .

Mentioning also @gmarchio

Anyhow it looks good and probably something that although will not be used often still can help with some expert workloads i.e compare clustering algs behaviour.

CI Result SUCCESS (hash f543a1c9)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests		N/A	N/A	N/A

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12829]

Job restarted due to technical problems with the CI server (which are fixed now)

Jenkins please retry a build

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

CI Result FAILURE (hash f543a1c9)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 2, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12855]

Compilation errors are due to the replacement of the gperftools on the CVFMS. (should be fixed now)

Jenkins please retry a build

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

CI Result FAILURE (hash f543a1c9)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 12941]

It looks like there's a CMake warning introduced by these changes:

CMake Warning at /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.13/InstallArea/x86_64-centos7-gcc8-opt/cmake/modules/AtlasLibraryFunctions.cmake:61 (message):
Package CaloCalibHitRec doesn't declare public headers for library
CaloCalibHitRecLib
Call Stack (most recent call first):
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Calorimeter/CaloCalibHitRec/CMakeLists.txt:36 (atlas_add_library)

Could you take a look? Thanks!

MLB (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 79e9b6ba - change copyright years

Compare with previous version

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 79e9b6ba)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13333]

Clear now, approving.

pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

Hi @lheinric , could you please fix CMake warning? Thanks.

added review-user-action-required label

added 1 commit

• a6c27d34 - declare public headers

Compare with previous version

This merge request affects 1 package:

• Calorimeter/CaloCalibHitRec

Adding @pavol as watcher

added review-pending-level-1 label and removed review-approved review-user-action-required labels

@tsulaia done

Thanks. Will merge it once CI finishes

CI Result SUCCESS (hash a6c27d34)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13391]

merged

mentioned in commit 29cd7fca

added sweep:ignore label