Skip to content
Snippets Groups Projects

Use AtlasFieldCacheCondObj instead of IMagFieldSvc in MuonSegmentMakerTools

Merged Use AtlasFieldCacheCondObj instead of IMagFieldSvc in MuonSegmentMakerTools
nkoehler/athena:rec5469 into master
Merged Nicolas Koehler requested to merge nkoehler/athena:rec5469 into master

Hi,

this MR moves from using IMagFieldSvc towards using the thread-safe AtlasFieldCacheCondObj in MuonSegmentMakerTools. It fixes ATLASRECTS-5469.

Best, Nico

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 2 packages:

    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added MuonSpectrometer master review-pending-level-1 labels

    added MuonSpectrometer master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 35db41d5)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13143]

    • Matt LeBlanc
      Matt LeBlanc @mleblanc ·
      Resolved by Nicolas Koehler

      It looks like a lot of tests fail ...

      DataQuality_required-test and several others fail like this:

      RDOtoRDOTrigger 04:54:45 
RDOtoRDOTrigger 04:54:45 AttributeError: 'MuonSegmentMomentumFromField' object has no attribute 'HasSTgc'
RDOtoRDOTrigger 04:54:45 
RDOtoRDOTrigger 04:54:45 Py:Athena            INFO leaving with code 8: "an unknown exception occurred"

      q221Test-test:

      RDOtoRDOTrigger 04:42:03 AthAlgSeq                                   0     ERROR AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<Gaudi::Sequence>]): code FAILURE: PBASE::sysInitialize()
RDOtoRDOTrigger 04:42:03 AthAllAlgSeq                                0     ERROR Unable to initialize Algorithm AthSequencer/AthAlgSeq
RDOtoRDOTrigger 04:42:03 AthAllAlgSeq                                0     ERROR AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<Gaudi::Sequence>]): code FAILURE: PBASE::sysInitialize()
RDOtoRDOTrigger 04:42:03 AthAlgEvtSeq                                0     ERROR Unable to initialize Algorithm AthSequencer/AthAllAlgSeq
RDOtoRDOTrigger 04:42:03 AthAlgEvtSeq                                0     ERROR AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<Gaudi::Sequence>]): code FAILURE: PBASE::sysInitialize()
RDOtoRDOTrigger 04:42:03 AthMasterSeq                                0     ERROR Unable to initialize Algorithm AthSequencer/AthAlgEvtSeq
RDOtoRDOTrigger 04:42:03 DecisionSvc                                 0      INFO Inserting stream: StreamRDO with no Algs
RDOtoRDOTrigger 04:42:03 StreamRDO.StreamRDOTool                     0      INFO Initializing StreamRDO.StreamRDOTool - package version AthenaServices-00-00-00
RDOtoRDOTrigger 04:42:03 StreamRDO.StreamRDO_MakeEventStreamInfo     0      INFO Initializing StreamRDO.StreamRDO_MakeEventStreamInfo - package version OutputStreamAthenaPool-00-00-00
RDOtoRDOTrigger 04:42:03 StreamRDO                                   0      INFO Found HelperTools = PrivateToolHandleArray(['MakeEventStreamInfo/StreamRDO_MakeEventStreamInfo','Athena::ThinningCacheTool/ThinningCacheTool_StreamRDO'])
RDOtoRDOTrigger 04:42:03 StreamRDO                                   0      INFO Data output: tmp.RDO_TRIG
RDOtoRDOTrigger 04:42:03 StreamRDO                                   0      INFO I/O reinitialization...
RDOtoRDOTrigger 04:42:03 AthMasterSeq                                0     ERROR AthenaBaseComps/AthenaBaseComps/AthCommonDataStore.icc:43 (StatusCode AthCommonDataStore<PBASE>::sysInitialize() [with PBASE = AthCommonMsg<Gaudi::Sequence>]): code FAILURE: PBASE::sysInitialize()
RDOtoRDOTrigger 04:42:03 AthenaEventLoopMgr                          0     ERROR Unable to initialize Algorithm: AthMasterSeq
RDOtoRDOTrigger 04:42:03 AthenaEventLoopMgr                          0     ERROR Failed to initialize base class MinimalEventLoopMgr
RDOtoRDOTrigger 04:42:03 ServiceManager                              0     ERROR Unable to initialize Service: AthenaEventLoopMgr
RDOtoRDOTrigger 04:42:03 Py:Athena            INFO leaving with code 33: "failure in initialization"

      Could you take a look?

      MLB (L1)

  • Matt LeBlanc added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Nicolas Koehler added 1 commit

    added 1 commit

    • ae14ee1b - remove phased-out property settings

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Nicolas Koehler resolved all threads

    resolved all threads

  • Nicolas Koehler added 1 commit

    added 1 commit

    • f713ee73 - use BField.allToroidOn where possible

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash ae14ee1b)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13197]

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash f713ee73)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13210]

  • Nicolas Koehler added 99 commits

    added 99 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 8ff7146f)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :warning: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :warning: Athena: number of compilation errors 0, warnings 1
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13220]

  • Vakhtang Tsulaia
    Vakhtang Tsulaia @tsulaia ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • Nicolas Koehler added 14 commits

    added 14 commits

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • MuonSpectrometer/MuonConfig
    • MuonSpectrometer/MuonReconstruction/MuonRecExample
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMatchingTools
    • MuonSpectrometer/MuonReconstruction/MuonSegmentMakers/MuonSegmentMakerTools/MuonSegmentMomentum

    Adding @goetz ,@rosati ,@wleight ,@nkoehler as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
Please register or sign in to reply