Add and modify egamma triggers for ATR-21242

Adding and modifying egamma triggers for ATR-21242, including changing L1_EM24VHI to L1_EM22VHI everywhere in TriggerMenuMT LS2_v1. L1_(2)EM15VHI is desired but not in L1 menus, so using L1_(2)EM15VH for now.

unmarked as a Work In Progress

This merge request affects 4 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenu
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@jpanduro as watchers

added Trigger TriggerMenu master review-pending-level-1 labels

CI Result SUCCESS (hash 2f2778cd)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13550]

approved this merge request

added review-approved label and removed review-pending-level-1 label

Approved. BA (L1)

Hi @ckaldero,

unfortunatly, this one has picked up a merge conflict. Please resolve!

Thanks, Walter

added review-user-action-required label and removed review-approved label

added 141 commits

• 2f2778cd...46198016 - 139 commits from branch atlas:master
• 442614db - resolve by accepting theirs, will replace after re-running ART tests to generate new one
• 51f0e28f - attempt at a manual merge since tests were failing locally

Compare with previous version

This merge request affects 4 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TriggerTest
• Trigger/TriggerCommon/TriggerMenu
• Trigger/TriggerCommon/TriggerMenuMT

Adding @hartj ,@jpanduro as watchers

added review-pending-level-1 label and removed review-user-action-required label

I think this commit should fix it, but not entirely sure as local tests were failing for seemingly unrelated reasons. I don't have time to debug them at the moment so I'll wait and see what the CI reports, fingers crossed it is just some local misconfiguration and all is fine with this MR

CI Result FAILURE (hash 51f0e28f)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 8, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13600]

It looks like this failed for reasons unrelated to this MR, since the only thing I changed between the successful CI and the failed CI apart from the merge is a reference count list in TriggerTest

Same build failures seen here, so I guess I wait until that is fixed: http://atlas-computing.web.cern.ch/atlas-computing/links/distDirectory/gitwww/GITWebArea/nightlies/master/2020-05-06T2138/Athena/x86_64-centos7-gcc8-opt/Athena/

Created ATLINFR-3529

!32540 (merged) is what broke this

Since this is a known failure and it previously passed the CI, happy to re-approve. Clara (L1)

added review-approved label and removed review-pending-level-1 label