Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
athena
Manage
Activity
Members
Labels
Plan
Jira
Code
Merge requests
173
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
atlas
athena
Merge requests
!32649
CaloIdentifier: Fix cppcheck warnings.
Code
Review changes
Check out branch
Download
Patches
Plain diff
Merged
CaloIdentifier: Fix cppcheck warnings.
ssnyder/athena:cppcheck.CaloIdentifier-20200506
into
master
Overview
3
Commits
1
Pipelines
1
Changes
2
Merged
Scott Snyder
requested to merge
ssnyder/athena:cppcheck.CaloIdentifier-20200506
into
master
4 years ago
Overview
3
Commits
1
Pipelines
1
Changes
2
Expand
assert() with side effects.
0
0
Merge request reports
Compare
master
master (base)
and
latest version
latest version
715c0ab4
1 commit,
4 years ago
2 files
+
6
−
12
Inline
Compare changes
Side-by-side
Inline
Show whitespace changes
Show one file at a time
Files
2
Search (e.g. *.vue) (Ctrl+P)
Calorimeter/CaloIdentifier/test/calocell_id_test_common.cxx
+
3
−
9
Options
/*
Copyright (C) 2002-20
19
CERN for the benefit of the ATLAS collaboration
Copyright (C) 2002-20
20
CERN for the benefit of the ATLAS collaboration
*/
// $Id$
/**
* @file CaloIdentifier/test/calocell_id_test_common.cxx
* @author scott snyder
@@ -221,13 +220,8 @@ std::unique_ptr<CALOCELL_ID_T> make_calo_id_t (IdDictParser& parser,
fcal_id
.
release
(),
minifcal_id
.
release
(),
tile_id
.
release
());
assert
(
calo_id
->
initialize_from_dictionary
(
idd
)
==
0
);
//assert (calo_id->em_idHelper() == em_id);
//assert (calo_id->hec_idHelper() == hec_id);
//assert (calo_id->fcal_idHelper() == fcal_id);
//assert (calo_id->minifcal_idHelper() == minifcal_id);
//assert (calo_id->tile_idHelper() == tile_id);
int
stat
=
calo_id
->
initialize_from_dictionary
(
idd
);
assert
(
stat
==
0
);
return
calo_id
;
}
Loading