CMake (Python Installation) Fixes, master branch (2020.05.07.)
These changes are meant to fix the build errors that showed up last night because of !32540 (merged).
As discussed in !32540 (comment 3432479), the problem came from packages using atlas_install_python_modules( python/*.py )
, even though they didn't have any python files in them. So the removal of those calls is the primary intent here.
But while I was modifying the packages, I couldn't resist doing "general cleanups" in them as well.
Note that it's not impossible that the CI would fail on this, as the removals of the atlas_depends_on_subdirs(...)
calls may reveal some further build configuration errors in our code...
Merge request reports
Activity
added bugfix label
This merge request affects 8 packages:
- Database/AthenaPOOL/RootFileTools
- DetectorDescription/GeoModel/GeoModelStandalone/DumpGeo
- InnerDetector/InDetConditions/BeamSpotConditions
- LArCalorimeter/LArDetDescr
- MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
- MuonSpectrometer/MuonReconstruction/MuonRecUtils/MuonStationIntersectSvc
- TileCalorimeter/TileSimUtils
- Tracking/Acts/ActsInterop
Adding @goetz ,@amorley ,@harkusha ,@wleight ,@pavol ,@sroe ,@csuster ,@mnowak ,@pagessin ,@solodkov ,@rosati ,@nkoehler ,@ssnyder ,@rbianchi as watchers
mentioned in merge request !32540 (merged)
CI Result FAILURE (hash 39948d8c)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13628]- Resolved by Nicolas Koehler
Could these updates have caused that test failure?2020-05-07T125926 CEST TrigValSteering INFO Running LogMerge_Reco_tf merging logs ['log.HITtoRDO', 'log.RDOtoRDOTrigger', 'log.RAWtoESD', 'log.ESDtoAOD', 'log.PhysicsValidation', 'log.RAWtoALL', 'athfile-5582-564e0e20-37b4-4798-b93a-9598a7f929e6.log.txt'] into athena.merged.log 2020-05-07T125927 CEST TrigValSteering INFO Running CountRefComp step using command: regtest.pl --linematch ".*" --inputfile athena.merged.regtest --reffile /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/data/TrigAnalysisTest/ref_RDOtoRDOTrig_mt1_build.ref 2>&1 | tee CountRefComp.log; exit ${PIPESTATUS[0]} --- /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/data/TrigAnalysisTest/ref_RDOtoRDOTrig_mt1_build.ref 2020-05-06 15:39:21.911548711 +0200 +++ ref_RDOtoRDOTrig_mt1_build.ref.new 2020-05-07 12:59:27.147137231 +0200 @@ -3,6 +3,6 @@ TrigSignatureMoniMT INFO -- #3136730292 Features 6 149 7 - - TrigSignatureMoniMT INFO HLT_2e17_lhvloose_L12EM3 #1767768251 -TrigSignatureMoniMT INFO -- #1767768251 Events 20 20 1 1 1 0 - 0 -TrigSignatureMoniMT INFO -- #1767768251 Features 2 15 3 0 - +TrigSignatureMoniMT INFO -- #1767768251 Events 20 20 0 0 0 0 - 0 +TrigSignatureMoniMT INFO -- #1767768251 Features 0 0 0 0 - TrigSignatureMoniMT INFO HLT_2e3_etcut_L12EM3 #2613484113 TrigSignatureMoniMT INFO -- #2613484113 Events 20 20 20 20 20 - - 20 === Alert! FAILURE input file (+) differs from reference (-) If this change is understood, to update the reference file please type: cp /var/lib/jenkins/workspace/CI-test-driver/CI-test-driver_32691_43929/Athena/Trigger_athena_MC/test_trigAna_RDOtoRDOTrig_mt1_build/ref_RDOtoRDOTrig_mt1_build.ref.new /build2/ci-builds/master/Athena/build/Athena/x86_64-centos7-gcc8-opt/data/TrigAnalysisTest/ref_RDOtoRDOTrig_mt1_build.ref
Not impossible, but I'd be very surprised...
added review-approved label and removed review-pending-level-1 label
mentioned in commit 27079582
added sweep:ignore label