Externals and flake8_atlas Update, master branch (2020.05.07.)

Updated all projects to atlasexternals-2.0.67.

The list of changes wrt. atlasexternals-2.0.65 are (atlasexternals@2.0.65...2.0.67):

• Copied POST_BUILD_CMD into atlas_install_generic(...), and made it a "list type" parameter;
  • Also updated the handling of ATLAS_PYTHON_CHECKER to deal correctly with list variables;
• Updated flake8_atlas not to fail when no python files are given to it, in case the user makes a mistake that would result in this;
• Made flake8_atlas process sub-directories correctly.

At the same time updated how AthGeneration and Athena would set up the usage of flake8_atlas during the build, by modifying the setup of ATLAS_FLAKE8 and ATLAS_PYTHON_CHECKER.

Also added a pre-configuration file to AthGeneration to make sure that when we build a package against an AthGeneration nightly/release, by default that build would use the same flake8_atlas settings as the underlying nightly/release.

This is to fix the issues @fwinkl advertised in

https://groups.cern.ch/group/hn-atlas-offlineSWDevelopment/Lists/Archive/Flat.aspx?RootFolder=%2Fgroup%2Fhn%2Datlas%2DofflineSWDevelopment%2FLists%2FArchive%2Fmaster%2Cr06%20broken&FolderCTID=0x01200200FBC5CE5673348640AB112EE6AB5B8297

, and which we discussed (mainly) in !32540 (comment 3432479).

added full-build label

Note that I decided against using full-unit-tests on this one. Since I'd like to push this in as quickly as physically possible... (I did a bunch of local tests with the changes today...)

build area is cleaned as MR is labeled as full-build

This merge request affects 6 packages:

• Projects/AnalysisBase
• Projects/AthDataQuality
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/VP1Light

Adding @jchapman ,@akraszna ,@krumnack ,@vpascuzz ,@rbianchi as watchers

added Build master review-pending-level-1 labels

added RC Attention Required urgent labels and removed Build master review-pending-level-1 labels

added Build master review-pending-level-1 labels

You were updating the labels at the same time as the robot was doing the same thing...

CI Result FAILURE (hash 9d841ce9)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 3
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13644]

It seems that the update to move POST_BUILD_CMD to atlas_install_generic(...) did not work as intended after all.

I had to dig into the cmake_build.log file on the CI node to find what has actually gone wrong.

...
[ 34%] Generating ../../../x86_64-centos7-gcc8-opt/python/TriggerJobOpts/CombinedSliceFlags.pyc
make[1]: *** No rule to make target `Trigger/TriggerCommon/TriggerMenu/CMakeFiles/test.dir/all', needed by `Trigger/TriggerCommon/TriggerMenu/CMakeFiles/TriggerMenuPythonInstall.dir/all'.
[ 34%] Generating CMakeFiles/pythonBytecode/python/api/TriggerEnums.pyc
...
[100%] Built target AthenaConfdbMerge
[100%] Built target AthenaClidMerge
[100%] Built target AthenaConfdb2Merge
[100%] Built target AthenaComponentsMerge
make[1]: Target `all' not remade because of errors.
make: *** [all] Error 2
make: Target `default_target' not remade because of errors.

Although with all the "project level merging" seemingly succeeding, I'm not really sure why so many of the tests failed. But those should clearly be tied to this build failure somehow nevertheless...

added review-user-action-required label and removed review-pending-level-1 label

mentioned in commit fwinkl/atlasexternals@41943031

mentioned in merge request atlasexternals!677 (merged)

mentioned in merge request atlasexternals!678 (closed)

added 1 commit

• e6e74e57 - Updated all projects to atlasexternals-2.0.67.

Compare with previous version

build area is cleaned as MR is labeled as full-build

This merge request affects 6 packages:

• Projects/AnalysisBase
• Projects/AthDataQuality
• Projects/AthGeneration
• Projects/AthSimulation
• Projects/Athena
• Projects/VP1Light

Adding @jchapman ,@akraszna ,@krumnack ,@vpascuzz ,@rbianchi as watchers

added review-pending-level-1 label and removed review-user-action-required label

changed the description