Move from MuonIdHelperTool to MuonIdHelperSvc (10)

Hi,

this MR uses MuonIdHelperSvc instead of MuonIdHelperTool in several MuonCnv packages.

Best, Nico

WARNING: big files (>100K) are found in the changeset

128K in file MuonSpectrometer/MuonCnv/MuonTGC_CnvTools/src/TgcRdoToPrepDataToolCore.cxx

This merge request affects 8 packages:

• MuonSpectrometer/MuonCnv/MuonByteStreamCnvTest
• MuonSpectrometer/MuonCnv/MuonJiveXML
• MuonSpectrometer/MuonCnv/MuonMDT_CnvTools
• MuonSpectrometer/MuonCnv/MuonPrdSelector
• MuonSpectrometer/MuonCnv/MuonPrepRawDataProviderTools
• MuonSpectrometer/MuonCnv/MuonRdoToPrepData
• MuonSpectrometer/MuonCnv/MuonTGC_CnvTools
• graphics/VP1/VP1Systems/VP1TrackSystems

Adding @rosati ,@wleight ,@nkoehler ,@rbianchi as watchers

added EventDisplay MuonSpectrometer master review-pending-level-1 labels

CI Result SUCCESS (hash e020953b)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 13780]

Looks good and CI clean, scaling to L2 since MR have huge size, --L1

added review-pending-level-2 label and removed review-pending-level-1 label

Changes look fine, but @nkoehler could you please expand how are related to the description, those applied in the graphics?

resolved all threads

Fine for me, approving.

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit eac0947b

added sweep:ignore label