Enable AthenaSharedWriter in StandAlone mode.
This is a new feature extending Athena Shared I/O (writer first/only) to run stand alone outside of AthenaMP. It should not affect any existing functionality.
The MR also allows the SharedWriter and its client to be used in 'metadata only' mode, where the clients write event data directly, but metadata is handled/summarized by the SharedWriter. As new development, in master, with the new RoorTreeIndex navigation, this could be combine with using ROOT TMemFile and TBufferMerging to allow more concurrent output (to be presented at a Core SW meeting).
Merge request reports
Activity
JobOption example for my own reference
added 111 commits
-
e51e1853...f969f47d - 110 commits from branch
atlas:master
- 090c31a5 - Merge remote-tracking branch 'upstream/master' into AthenaSharedWriter_StandAlone
-
e51e1853...f969f47d - 110 commits from branch
added 51 commits
-
090c31a5...7a05c539 - 50 commits from branch
atlas:master
- bcdeee6b - Merge remote-tracking branch 'upstream/master' into AthenaSharedWriter_StandAlone
-
090c31a5...7a05c539 - 50 commits from branch
added full-unit-tests label
added Core Database master review-pending-level-1 labels
CI Result FAILURE (hash 09cceeda)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14448]added review-user-action-required label and removed review-pending-level-1 label
added 114 commits
-
09cceeda...766d3f28 - 113 commits from branch
atlas:master
- c6c3744b - Merge remote-tracking branch 'upstream/master' into AthenaSharedWriter_StandAlone
-
09cceeda...766d3f28 - 113 commits from branch
For AnalysisBase, all failures:
The following tests FAILED: 94 - xAODDataSource_dataFrame_pytest_ctest (Failed) 163 - xAODTriggerCnv_ut_xaodtriggercnv_triggermenumetadatatool_test_ctest (Failed) 167 - FTagAnalysisAlgorithms_testJobData_ctest (Failed) 168 - FTagAnalysisAlgorithms_testJobFullSim_ctest (Failed) 169 - FTagAnalysisAlgorithms_testJobFastSim_ctest (Failed) 177 - TriggerAnalysisAlgorithms_TriggerAlgorithmsTestJobData_ctest (Failed) 178 - TriggerAnalysisAlgorithms_TriggerAlgorithmsTestJobFullSim_ctest (Failed) 179 - TriggerAnalysisAlgorithms_TriggerAlgorithmsTestJobFastSim_ctest (Failed) 195 - PileupReweighting_ut_PRWExample_test_ctest (Failed) 196 - ReweightUtils_ut_ParticleScaleFactorTool_test_ctest (Failed) 233 - DiTauMassTools_missingmasstool_test_ctest (Failed) 234 - DiTauMassTools_missingmasstool_test_python_ctest (Failed) 236 - JetTileCorrection_ut_JetTileCorrectionTool_data_ctest (Failed) 237 - JetTileCorrection_ut_JetTileCorrectionTool_mc_ctest (Failed) 244 - TrigBunchCrossingTool_flake8_scripts_ctest (Failed) [ERROR_MESSAGE]
also appear in nightly: https://bigpanda.cern.ch/testsview/?nightly=master_AnalysisBase_x86_64-centos7-gcc8-opt&rel=2020-05-26T0447&ar=x86_64-centos7-gcc8-opt&proj=AnalysisBase and are not related to this MR.
Edited by Peter Van GemmerenSimilar for AthGeneration:
438/473 Test #439: McParticleEvent_TruthParticle_test_ctest ..............................***Failed 0.89 sec
For Athena:
487/1800 Test #294: AthenaMonitoring_ExampleMonitorAlgorithm_test_ctest .......................***Timeout 120.03 sec 582/1800 Test #483: xAODDataSource_dataFrame_pytest_ctest .....................................***Failed 27.23 sec 987/1800 Test #928: SiSPSeededTrackFinder_SiSPSeededTracksStandalone_ctest ....................***Failed 16.22 sec 1237/1800 Test #1206: McParticleEvent_TruthParticle_test_ctest ..................................***Failed 1.41 sec 1239/1800 Test #1207: McParticleEventTPCnv_TruthParticleContainerCnv_p5_test_ctest ..............***Failed 2.50 sec 1240/1800 Test #1208: McParticleEventTPCnv_TruthParticleContainerCnv_p6_test_ctest ..............***Failed 2.52 sec
574/1800 Test #475: StoreGateTests_PyClidsTestWriter_ctest ....................................***Failed 14.85 sec
Runs locally.
removed full-unit-tests label
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash c6c3744b)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14614]This merge request affects 9 packages:
- Control/AthenaIPCTools
- Control/AthenaKernel
- Control/AthenaMP
- Control/AthenaServices
- Database/APR/PersistencySvc
- Database/APR/RootStorageSvc
- Database/AthenaPOOL/AthenaPoolCnvSvc
- Database/AthenaRoot/AthenaRootComps
- Event/ByteStreamCnvSvc
added EDM label
CI Result FAILURE (hash 44b14d9b)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14678]This merge request affects 10 packages:
- Control/AthenaIPCTools
- Control/AthenaKernel
- Control/AthenaMP
- Control/AthenaServices
- Database/APR/PersistencySvc
- Database/APR/RootStorageSvc
- Database/AthenaPOOL/AthenaPoolCnvSvc
- Database/AthenaRoot/AthenaRootComps
- Event/ByteStreamCnvSvc
- Event/EventOverlay/OverlayByteStreamAlgs
Adding @jchapman ,@ahaas ,@tkharlam ,@tadej ,@ssnyder ,@mnowak as watchers
added Overlay label
CI Result SUCCESS (hash 565f4149)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14724]added review-pending-level-2 label and removed review-pending-level-1 label
Hello @gemmeren it would be possible to add some more information in this MR description?
Changes look fine to me, but being this some core software, it might be relevant to specify impact (if any - since StandAlone is in the title) on users and other packages.
In case there is, it might be safer asking an expert to look into this. Could you clarify?
Thanks, Sergio
added review-user-action-required label and removed review-pending-level-2 label
removed review-user-action-required label
added review-approved label
mentioned in commit c8918dcd
added sweep:ignore label