Skip to content
Snippets Groups Projects

Fix for reusing of externals build

Merged Frank Winklmeier requested to merge fwinkl/athena:cache_externals into master

Second try to caching the externals build. The improvement compared to !32965 (merged) (reverted in !33206 (merged)) is to include the upstream (Athena) project version in the externals stamp file. That way we are rebuilding (and more importantly reinstalling) the externals in case the upstream version changes. Otherwise it would not be found under the release version (ATLINFR-3018).

Also implement the same caching now for AnalysisBase.

cc @akraszna

Edited by Frank Winklmeier

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Winklmeier added 15 commits

    added 15 commits

    • ba72bcad...739e797f - 12 commits from branch atlas:master
    • e4d22967 - Reuse existing externals build if possible
    • d237ecf8 - Fix for reusing existing externals build
    • ffb9072b - Do not use BINARY_TAG for externals stamp file

    Compare with previous version

  • This merge request affects 4 packages:

    • Projects/AnalysisBase
    • Projects/AthGeneration
    • Projects/AthSimulation
    • Projects/Athena

    Adding @jchapman ,@akraszna ,@krumnack ,@vpascuzz ,@rbianchi as watchers

  • This merge request affects 4 packages:

    • Projects/AnalysisBase
    • Projects/AthGeneration
    • Projects/AthSimulation
    • Projects/Athena

    Adding @jchapman ,@akraszna ,@krumnack ,@vpascuzz ,@rbianchi as watchers

  • This merge request affects 4 packages:

    • Projects/AnalysisBase
    • Projects/AthGeneration
    • Projects/AthSimulation
    • Projects/Athena

    Adding @jchapman ,@akraszna ,@krumnack ,@vpascuzz ,@rbianchi as watchers

  • Frank Winklmeier resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash ffb9072b)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14715]

  • Looks fine, CI is good and all threads are resolved. Approving. Clara (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 54a8d3f2

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading