Skip to content
Snippets Groups Projects

BCM overlay

Merged BCM overlay
janovak/athena:BCMoverlay into master
All threads resolved!
Merged Jakob Novak requested to merge janovak/athena:BCMoverlay into master
All threads resolved!

This MR introduces BCM overlay algorithm. In addition, tests for this algorithm have been prepared. @tadej @jchapman

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@tkharlam ,@tadej as watchers

  • ATLAS Robot added Digitization EDM InnerDetector Overlay master review-pending-level-1 labels

    added Digitization EDM InnerDetector Overlay master review-pending-level-1 labels

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash e2d37581)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14667]

  • Magdalena Slawinska added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • M
    Magdalena Slawinska @maslawin ·
    Developer

    Please address discussions and have a look at

    TEST FAILURE: OverlayTier0Test_required returned code 255

    Magdalena (L1 shifter)

  • Jakob Novak added 2 commits

    added 2 commits

    • 179915a7 - Implementing comments
    • 1c981f7d - Remove filling pulse vectors in time order, introduce sorting after overlaying

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@tkharlam ,@tadej as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 1c981f7d)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14777]

  • Tadej Novak
  • Tadej Novak
  • Tadej Novak
  • Magdalena Slawinska added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • M
    Magdalena Slawinska @maslawin ·
    Developer

    Please address discussions and have a look at

    TEST FAILURE: OverlayTier0Test_required returned code 255

    Magdalena (L1 shifter)

  • Jakob Novak added 3 commits

    added 3 commits

    • 5fc0c543 - Implementing comments, improving style, removing unnecessary if clause
    • 23bf86ff - Symmetric treatment of sig and bkg pulses, smaller style corrections
    • b8848cdf - Replacing BCM_Pulse pointers with smart pointers

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 3 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@tkharlam ,@tadej as watchers

  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash b8848cdf)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14889]

  • Tadej Novak added Run2-MCOverlay-output-changed label

    added Run2-MCOverlay-output-changed label

  • Pavol Strizenec resolved all threads

    resolved all threads

  • Pavol Strizenec
    Pavol Strizenec @pavol ·
    Developer

    Hi @janovak ,

    if this brings changes in overlay output, new reference file should be probably produced and included into Tier0ChainTests definition... I think @jchapman could help you to put new file on eos...

    Thanks,
          Pavol [as L2 MR shifter]
  • Pavol Strizenec added review-user-action-required label

    added review-user-action-required label

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    Hi @pavol,

    John is away for the next few weeks. I will help Jakob update the reference (we were actually trying to do it already, but AMI was offline).

  • Jakob Novak added 1 commit

    added 1 commit

    • 5c2d55b7 - BCM collection size check, swithcing to the new overlay test file

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Tools/PROCTools

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@amete ,@tkharlam ,@tadej as watchers

  • ATLAS Robot added Tools label and removed review-user-action-required label

    added Tools label and removed review-user-action-required label

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 5c2d55b7)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15018]

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Tools/PROCTools

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@amete ,@tkharlam ,@tadej as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :negative_squared_cross_mark: CI Result FAILURE (hash 5c2d55b7)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :o: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :cloud: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :o: Athena: number of compilation errors 1, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15071]

  • Tadej Novak
    Tadej Novak @tadej ·
    Developer

    Jenkins please retry a build

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 4 packages:

    • Event/EventOverlay/EventOverlayJobTransforms
    • InnerDetector/InDetDigitization/BCM_Digitization
    • InnerDetector/InDetRawAlgs/InDetOverlay
    • Tools/PROCTools

    Adding @jchapman ,@goetz ,@sroe ,@ahaas ,@amete ,@tkharlam ,@tadej as watchers

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 5c2d55b7)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15086]

  • Magdalena Slawinska added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Walter Lampl merged

    merged

  • Walter Lampl mentioned in commit 23a44317

    mentioned in commit 23a44317

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply