Acts mat map
Implementation of the Acts surface material mapping.
Some other tool necessary for the mapping and its validation where also added :
- A Geometry writer that write Geometry and material map as json files
- A converter from materialsteps to materialtracks (as the later are used by the Acts from the material mapping)
- Material decoration was added to the tracking geometry
- Material interaction was added to the extrapolation
- A separate algorithm for material validation
An example of the validation is shown below : Ratio_Val_geant_mat_X0_Eta.pdf
The material mapping has been implemented for the Pixel and SCT. For the TRT and the Calorimeter we are looking to implement them as volume map. The volume mapping will be implemented once v0.23 of Acts is available in the external.
Merge request reports
Activity
added review-pending-level-1 label
CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals cmake make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14773]added review-user-action-required label and removed review-pending-level-1 label
added 284 commits
-
8a60d4cd...07d2aec7 - 283 commits from branch
atlas:master
- 3677395f - :Merge remote-tracking branch 'upstream/master' into acts-mat-map
-
8a60d4cd...07d2aec7 - 283 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals cmake make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14891] CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals cmake make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14895] CI Result FAILUREAthena AthSimulation AnalysisBase AthGeneration externals cmake make N/A N/A N/A N/A required tests N/A N/A N/A N/A optional tests N/A N/A N/A N/A Due to problems in externals build or cmake configuration the job is stopped, results are not available on the ATLAS CI monitor Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14953]Dear @corentin , the CI failed three times. Do you know if the failure is related to your changes? There seems to be some problem with the cmake configuration - according to the page
https://atlas-sit-ci.cern.ch/job/CI-MERGE-REQUEST-CC7/14953/
L1 shifter
added review-user-action-required label
Hm. The cmake failure is this:
14:00:20 CMake Error at /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.15/InstallArea/x86_64-centos7-gcc8-opt/cmake/modules/AtlasLibraryFunctions.cmake:144 (add_library): 14:00:20 Target "ActsGeometry" links to target "nlohmann_json::nlohmann_json" but 14:00:20 the target was not found. Perhaps a find_package() call is missing for an 14:00:20 IMPORTED target, or an ALIAS target is missing? 14:00:20 Call Stack (most recent call first): 14:00:20 /build2/ci-builds/master/Athena/install/AthenaExternals/22.0.15/InstallArea/x86_64-centos7-gcc8-opt/cmake/modules/AtlasLibraryFunctions.cmake:328 (atlas_add_library) 14:04:47 /var/lib/jenkins/workspace/CI-MERGE-REQUEST-CC7/master/Tracking/Acts/ActsGeometry/CMakeLists.txt:56 (atlas_add_component)
Our JSON plugin depends publicly on
nlohmann::json
, so I guess simply adding afind_package(nlohmann_json)
as the log suggests might help. Can you try that @corentin?
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
added 174 commits
-
3677395f...a418042a - 171 commits from branch
atlas:master
- 92c90c12 - implemented comments
- 8fdc7294 - implemented comments
- 95e606b4 - Merge remote-tracking branch 'upstream/master' into acts-mat-map
Toggle commit list-
3677395f...a418042a - 171 commits from branch
removed review-user-action-required label
CI Result FAILURE (hash 44b9e1df)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15003] CI Result FAILURE (hash 95e606b4)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15002] CI Result SUCCESS (hash a1500f25)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15013]added review-user-action-required label and removed review-pending-level-1 label
added 227 commits
-
a1500f25...23a44317 - 226 commits from branch
atlas:master
- 564220be - Merge remote-tracking branch 'upstream/master' into acts-mat-map
-
a1500f25...23a44317 - 226 commits from branch
added review-pending-level-1 label and removed review-user-action-required label
CI Result SUCCESS (hash 564220be)Athena AthSimulation AnalysisBase AthGeneration externals cmake make required tests optional tests Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15231]- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire
- Resolved by Corentin Allaire