Skip to content
Snippets Groups Projects

Acts mat map

Merged Corentin Allaire requested to merge corentin/athena:acts-mat-map into master

Implementation of the Acts surface material mapping.

Some other tool necessary for the mapping and its validation where also added :

  • A Geometry writer that write Geometry and material map as json files
  • A converter from materialsteps to materialtracks (as the later are used by the Acts from the material mapping)
  • Material decoration was added to the tracking geometry
  • Material interaction was added to the extrapolation
  • A separate algorithm for material validation

An example of the validation is shown below : Ratio_Val_geant_mat_X0_Eta.pdf

The material mapping has been implemented for the Pixel and SCT. For the TRT and the Calorimeter we are looking to implement them as volume map. The volume mapping will be implemented once v0.23 of Acts is available in the external.

Merge request reports

Approval is optional

Merged by Edward MoyseEdward Moyse 4 years ago (Jun 22, 2020 1:27pm UTC)

Merge details

  • Changes merged into master with 74ea2bd2.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Corentin Allaire added 174 commits

    added 174 commits

    Compare with previous version

  • This merge request affects 2 packages:

    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsGeometryInterfaces

    Adding @amorley ,@pagessin as watchers

  • This merge request affects 2 packages:

    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsGeometryInterfaces

    Adding @amorley ,@pagessin as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 44b9e1df)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15003]

  • added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsGeometryInterfaces

    Adding @amorley ,@pagessin as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 95e606b4)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15002]

  • :white_check_mark: CI Result SUCCESS (hash a1500f25)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15013]

  • Please resolve discussions and relabel.

    Magdalena (L1 shifter)

  • Corentin Allaire resolved all threads

    resolved all threads

  • Corentin Allaire added 227 commits

    added 227 commits

    • a1500f25...23a44317 - 226 commits from branch atlas:master
    • 564220be - Merge remote-tracking branch 'upstream/master' into acts-mat-map

    Compare with previous version

  • This merge request affects 2 packages:

    • Tracking/Acts/ActsGeometry
    • Tracking/Acts/ActsGeometryInterfaces

    Adding @amorley ,@pagessin as watchers

  • :white_check_mark: CI Result SUCCESS (hash 564220be)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15231]

  • Xiaozhong Huang
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading