Skip to content
Snippets Groups Projects

Remove defunct job option from ByteStreamInputSvc

Merged Frank Berghaus requested to merge berghaus/athena:FullFileName into master

The ByteStreamEventStorageInput service provided a legacy job option called FullFileName to specify bytestream input. With the move to EventSelector this option was all but removed from ByteStreamEventInputSvc. The EventSelectorByteStream provieded the input option to specify input. It captured the FullFileName option of the InputSvc. This commit removes the relevant parts of the ByteStreamEventStorageInputSvc and EventSelectorByteStream. It also attempts to move all references in other job options (unless they specify being for an older release).

@gemmeren @mnowak

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Frank Berghaus added 1 commit

    added 1 commit

    • 5bbe640e - Get EventSelector from service manager in LAr job options

    Compare with previous version

  • This merge request affects 54 packages. Since this is a long list, I will not print it here.

    Adding @jchapman ,@cgrefe ,@rosati ,@kwhalen ,@ebergeas ,@battagl ,@asonay ,@wiedenma ,@solodkov ,@cmorenom ,@bernius ,@ahaas ,@stsuno ,@fwinkl ,@oda ,@nkoehler ,@afaulkne ,@goetz ,@orlando ,@amorley ,@wleight ,@ibragimo ,@pavol ,@tkharlam ,@sroe ,@csuster ,@harkusha ,@calfayan ,@vpascuzz ,@tadej ,@rbielski ,@gavrilen as watchers

    • Resolved by Walter Lampl

      :negative_squared_cross_mark: CI Result FAILURE (hash 5bbe640e)

      Athena AthSimulation AnalysisBase AthGeneration
      externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
      required tests :o: :o: :white_check_mark: :white_check_mark:
      optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

      Full details available on this CI monitor view
      :white_check_mark: Athena: number of compilation errors 0, warnings 0
      :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
      :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
      :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
      :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14945]

  • Pavol Strizenec resolved all threads

    resolved all threads

  • Jenkins please retry a build

  • This merge request affects 54 packages. Since this is a long list, I will not print it here.

    Adding @jchapman ,@cgrefe ,@rosati ,@kwhalen ,@ebergeas ,@battagl ,@asonay ,@wiedenma ,@solodkov ,@cmorenom ,@bernius ,@ahaas ,@stsuno ,@fwinkl ,@oda ,@nkoehler ,@afaulkne ,@goetz ,@orlando ,@amorley ,@wleight ,@ibragimo ,@pavol ,@tkharlam ,@sroe ,@csuster ,@harkusha ,@calfayan ,@vpascuzz ,@tadej ,@rbielski ,@gavrilen as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash 5bbe640e)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :o: :o: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14949]

  • Jenkins please retry a build

  • This merge request affects 54 packages. Since this is a long list, I will not print it here.

    Adding @jchapman ,@cgrefe ,@rosati ,@kwhalen ,@ebergeas ,@battagl ,@asonay ,@wiedenma ,@solodkov ,@cmorenom ,@bernius ,@ahaas ,@stsuno ,@fwinkl ,@oda ,@nkoehler ,@afaulkne ,@goetz ,@orlando ,@amorley ,@wleight ,@ibragimo ,@pavol ,@tkharlam ,@sroe ,@csuster ,@harkusha ,@calfayan ,@vpascuzz ,@tadej ,@rbielski ,@gavrilen as watchers

  • :white_check_mark: CI Result SUCCESS (hash 5bbe640e)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 14992]

  • Walter Lampl resolved all threads

    resolved all threads

  • added review-approved label and removed review-pending-level-1 label

  • Walter Lampl mentioned in commit fbfa671e

    mentioned in commit fbfa671e

  • merged

  • Frank Berghaus mentioned in merge request !33563 (merged)

    mentioned in merge request !33563 (merged)

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading