Improve and move metadata suite to RecExRecoTest

Move meta-data test suite into RecExRecoTest as discussed at the core meeting. Allow user to specify inputs and references for inclreased flexibility. To manage this this also introduces a configuration class to manage how to run the transforms and test the metadata.

TODO:

• Find a home for the input files
• Fimd a home for the reference files

Adding @tadej @tsulaia @gemmeren @mnowak

changed the description

To be honest I think we should try to generalise this also to other workflows (e.g. Simulation and Derivations) so I'm not sure we need to move the test. But I'll let others comment.

added 32 commits

• c26f2da5...048f41fd - 28 commits from branch atlas:master
• 4839ea17 - Rework meta-data test suite
• e177294b - Add --AMI to transform command
• 8c8ff37c - Fix reference file arguments
• c8b1f07f - Put metadata-test command into path

Compare with previous version

added 941 commits

• c8b1f07f...48d92572 - 937 commits from branch atlas:master
• a7d25cda - Rework meta-data test suite
• e93d020b - Add --AMI to transform command
• 3426171c - Fix reference file arguments
• 671eb15d - Put metadata-test command into path

Compare with previous version

added 1 commit

• 7ad1e40d - Readd the AMI tag option

Compare with previous version

added 3 commits

• cf34be67 - Style clean-up
• ecb8ec70 - Remove identical content in diff style display
• 3eafa225 - Loop over all keys of original dictionary

Compare with previous version

added 1 commit

• 5af8ab49 - Produce summary of long contents

Compare with previous version

added 1 commit

• 4af6d436 - Set style to display metadata differences

Compare with previous version

added 1150 commits

• 4af6d436...e2c1ebdb - 1139 commits from branch atlas:master
• 2b6d0213 - Rework meta-data test suite
• 2c6f3215 - Add --AMI to transform command
• 864e354e - Fix reference file arguments
• 4b0f1576 - Put metadata-test command into path
• ab71c5d3 - Readd the AMI tag option
• 43e3d2e7 - Style clean-up
• 79d3ff32 - Remove identical content in diff style display
• 6797826b - Loop over all keys of original dictionary
• a9d0af5c - Produce summary of long contents
• aa8fbac5 - Set style to display metadata differences
• c62b3e02 - Grab input and referece from CVMFS by default

Compare with previous version

marked the checklist item Find a home for the input files as completed

Thank you or finding a home for the input files @tadej

As mentioned at the meeting yesterday, comparing to references produced in release 21 is difficult, as there are many changes in EventFormat and EventSteamInfo. Object versions change, though that seems expected. Instead of putting the references on CVMFS I'll compare serial vs threaded in the script.

Some algorithms in 22 expect input collections from the ESD which are not produced in release 21 (particle flow comes to mind). I can either disable those components or produce input ESDs on the fly. What is the better approach?

added 1 commit

• 82c787cf - Use output of serial transform as reference

Compare with previous version

marked the checklist item Fimd a home for the reference files as completed

Hi @berghaus,

Thanks for the heads up. If the command did not change (meta-diff.py -x diff -s etc), then we are fine.

Cheers, Tulay

resolved all threads

unmarked as a Work In Progress

This merge request affects 3 packages:

• Control/AthenaServices
• Reconstruction/RecExample/RecExRecoTest
• Tools/PyUtils

Adding @goetz ,@ssnyder as watchers

added Core Reconstruction Tools master review-pending-level-1 labels