Skip to content
Snippets Groups Projects

xAODTriggerCnv+xAODTauCnv: cmake fixes

Merged Scott Snyder requested to merge ssnyder/athena:cmake.xAODTriggerCnv-20200610 into master
All threads resolved!

Library dependency fixes.

Define interface libraries for exported headers.

Merge request reports

Pipeline #1706616 failed

Pipeline failed for a810c525 on ssnyder:cmake.xAODTriggerCnv-20200610

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 4 years ago (Jun 16, 2020 10:31am UTC)

Merge details

  • Changes merged into master with 80283e3f.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Scott Snyder added 1 commit

    added 1 commit

    • a810c525 - remove redundant atlas_install_headers

    Compare with previous version

  • Author Developer

    Thanks. Should be fixed now.

  • This merge request affects 2 packages:

    • Event/xAOD/xAODTauCnv
    • Event/xAOD/xAODTriggerCnv

    Adding @tamartin ,@martindl ,@akraszna ,@adbailey ,@xiaozhon as watchers

  • :negative_squared_cross_mark: CI Result FAILURE (hash a810c525)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :o: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15331]

  • Changing label to review-user-action-required until all threads are resolved. Please switch back when ready.

    Xiaozhong (L1)

  • The failing unit test is a known issue and the changes are fine. Approving.

    Jason (L1)

  • Adam Edward Barton resolved all threads

    resolved all threads

  • mentioned in commit 80283e3f

  • Please register or sign in to reply
    Loading