Skip to content
Snippets Groups Projects

PrepRawDataComparisonFunction : major cleanup

Merged PrepRawDataComparisonFunction : major cleanup
ATLAS-EGamma/athena:PrepRawDataComparisonFunction_no_dynCast_default_cleanup into master
All threads resolved!
Merged Christos Anastopoulos requested to merge ATLAS-EGamma/athena:PrepRawDataComparisonFunction_no_dynCast_default_cleanup into master
All threads resolved!
  • Use value rather than prt for the data members
  • default copy ctor assingment
  • Avoid dynamic casts
  • clean up a bit the logic
  • ....

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Shaun Roe
  • Shaun Roe
  • Christos Anastopoulos added 1 commit

    added 1 commit

    Compare with previous version

  • Christos Anastopoulos resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Tracking/TrkEvent/TrkEventUtils

    Adding @amorley as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1bb72135)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15478]

  • Baida Achkar
    Baida Achkar @bachkar ·

    @christos . Sorry, copyright needs to be fixed. Thanks. BA as L1.

  • Christos Anastopoulos added 1 commit

    added 1 commit

    Compare with previous version

  • Christos Anastopoulos
    Christos Anastopoulos @christos ·
    Author Developer

    Copyright updated

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • Tracking/TrkEvent/TrkEventUtils

    Adding @amorley as watcher

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 6c0ad9c2)

    Athena AthSimulation AnalysisBase AthGeneration
    externals :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    required tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:
    optional tests :white_check_mark: :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthSimulation: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15512]

  • Jason Robert Veatch
    Jason Robert Veatch @jveatch ·
    Developer

    The changes look fine and there are no CI issues. Approving.

    Jason (L1)

  • Jason Robert Veatch added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • Adam Edward Barton mentioned in commit c5bba65b

    mentioned in commit c5bba65b

  • Adam Edward Barton merged

    merged

  • Atlas Nightlybuild added sweep:ignore label

    added sweep:ignore label

    • Please register or sign in to reply