Improvements for re-reco from ESD

These are some things that I have had to fix to get MuonCombined reconstruction working from ESDs.

There will be a separate MuonCombined MR once I have it fully working, but these commits are kind of peripheral.

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Tracking/TrkConfig

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

added MuonSpectrometer Reconstruction Tracking master review-pending-level-1 labels

changed title from Improvements for ESD reading to Improvements for re-reco from ESD

changed the description

Hi @emoyse,

fine for me to merge it. I plan to do a proper indentation via a formatter anyway, if the code runs in MT.

Best, Nico

CI Result SUCCESS (hash 1025ff48)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15644]

added review-pending-level-2 label and removed review-pending-level-1 label

resolved all threads

resolved all threads

resolved all threads

added 1 commit

• 1c9ea0e3 - Revert "Clean indentation"

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonReconstruction/MuonTrackMakers/MuonTrackMakerTools/MuonTrackFinderTools
• Reconstruction/MuonIdentification/MuonCombinedBaseTools
• Tracking/TrkConfig

Adding @goetz ,@rosati ,@wleight ,@nkoehler ,@amorley as watchers

added review-pending-level-1 label and removed review-pending-level-2 label

There are a few indentation changes which remain. Sorry - but they were in the same commit as important changes and I didn't want to spend too long on this.

resolved all threads

CI Result SUCCESS (hash 1c9ea0e3)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15713]

added review-pending-level-2 label and removed review-pending-level-1 label

Changes look fine, and according to discussions formatting will be handled in a next MR, hence approving.

added review-approved label and removed review-pending-level-2 label

mentioned in merge request !33983 (merged)

merged

mentioned in commit 4db50146

added sweep:ignore label