Replacement InDetBSErrContainer with IDCInDetBSErrContainer (ATLASRECTS-4971)

InDetBSErrContainer was not tread-safe.

Instead, The IDCInDetBSErrContainer is prepared.

Basically, this means PixelByteStreamErrorsTool is not necessary anymore and the BS error information can be directly accessed through IDCInDetBSErrContainer.

There is some extension of the original IDCInDetBSErrContainer which only stored "module-level information. But it is now expanded to FE-level information.

added InnerDetector Trigger master labels

This merge request affects 8 packages:

• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring

Adding @goetz ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

added DQ review-pending-level-1 labels

Please don't review

InnerDetector/InDetMonitoring/PixelMonitoring/src/PixelAthErrorMonAlg.cxx

This is now all lines are commented. I let DQ people to re-create new filling scheme since the retrieve method for the BS error information was changed.

Cheers, Soshi

And the BS errors are expanded FE granularity, the T0 test will be broken for q431. This is expected. But q221 should be same.

CI Result FAILURE (hash 9c6c0a60)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15767]

added 375 commits

• 9c6c0a60...bf898282 - 372 commits from branch atlas:master
• 70c6f609 - little update, mainly fix compiler error
• ea9dfbf5 - Merge remote-tracking branch 'upstream/master' into atlasrects-4971.v3
• 627448a5 - fix compiler error.

Compare with previous version

This merge request affects 9 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring

Adding @goetz ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

CI Result FAILURE (hash 627448a5)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15955]

Hi @stsuno, if no further implementations are required from your side and everyone involved is happy with the MR, could you please mark the related threads as resolved and resolve the rest? Please then feel free to return the label back and the MR will be ready for review. Thanks, L1

added review-user-action-required label and removed review-pending-level-1 label

added 343 commits

• 627448a5...8f05efa3 - 341 commits from branch atlas:master
• 4a205741 - reflect comments in MR.
• 7f141bdc - Merge remote-tracking branch 'upstream/master' into atlasrects-4971.v3

Compare with previous version

This merge request affects 10 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring
• InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation

Adding @goetz ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 7f141bdc)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16088]

Changing label to review-user-action-required until the discussions are resolved. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

resolved all threads

Hello, Can we merge? Cheers, Soshi

added review-pending-level-1 label and removed review-user-action-required label

Hi @stsuno, just FYI (and for the future) I learned today that we also need to change the label (just resolving all threads is not sufficient for proceeding with MR).

Hi, please have a look at

q431 Digest Diff with exit code: 1 Fri Jun 26 17:20:19 CEST 2020 The xAODDigest diff failed! The output (>) differs from the reference (<) The q431 TEST WARNING! q431xAODDigestTest returned code 2

Magdalena (L1 shifter)

added review-user-action-required label and removed review-pending-level-1 label

Hello,

This MR will change q431, because the ByteStreamError is applied to the FE-level, which was module level before.

Also, the old container is not filled now, thus, the ESD size is also different from the reference.

We need to update the reference.

Cheers, Soshi

added review-pending-level-1 label and removed review-user-action-required label

This merge request affects 10 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring
• InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation

Adding @goetz ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

CI Result FAILURE (hash 7f141bdc)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 16804]

This merge request affects 10 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring
• InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation

Adding @goetz ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

CI Result FAILURE (hash 7f141bdc)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 17013]

added 1133 commits

• 7f141bdc...6ca0be1f - 1131 commits from branch atlas:master
• 2bfa073a - Merge remote-tracking branch 'upstream/master' into atlasrects-4971.v3
• c6030a62 - update reference

Compare with previous version

This merge request affects 11 packages:

• InnerDetector/InDetCalibAlgs/PixelCalibAlgs
• InnerDetector/InDetConditions/InDetConditionsSummaryService
• InnerDetector/InDetConditions/PixelConditionsData
• InnerDetector/InDetConditions/PixelConditionsTools
• InnerDetector/InDetConditions/SCT_ConditionsTools
• InnerDetector/InDetEventCnv/InDetPrepRawDataToxAOD
• InnerDetector/InDetEventCnv/PixelRawDataByteStreamCnv
• InnerDetector/InDetExample/InDetRecExample
• InnerDetector/InDetMonitoring/PixelMonitoring
• InnerDetector/InDetRecAlgs/InDetPrepRawDataFormation
• Tools/PROCTools

Adding @goetz ,@amete ,@ibragimo ,@stsuno ,@kzoch ,@oda ,@battagl ,@sroe as watchers

added Tools label

added Run2-DataReco-output-changed label