CaloEvent: Fix cppcheck warnings.

• Issues with assertions with possible side effects.
• Redundant comparison.
• Prefer to initialize members in an initialization clause rather than a constructor body.

This merge request affects 1 package:

• Calorimeter/CaloEvent

Adding @pavol as watcher

added Calorimeter JetEtmiss master review-pending-level-1 labels

CI Result SUCCESS (hash afc9d91e)

	Athena	AthSimulation	AnalysisBase	AthGeneration
externals
cmake
make
required tests
optional tests

Full details available on this CI monitor view
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 15891]

Clear, approving,

   Pavol [as L2 MR shifter]

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit cd680975

added sweep:ignore label